Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-142315: Don't pass the "real path" of Pdb script target to system functions #142371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 12 commits into from
Dec 10, 2025
+86 −7
Merged

gh-142315: Don't pass the "real path" of Pdb script target to system functions #142371

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7050770
Pick target depending on preconditions
johnslavik Dec 7, 2025
2d8c231
Clarify the news fragment
johnslavik Dec 7, 2025
7196224
Add test capturing missed expectation.
jaraco Dec 7, 2025
5b12904
Add more idiomatic safe realpath helper
johnslavik Dec 7, 2025
3058faf
Merge branch 'jaraco/gh-142315/regr-test' into pdb-realpath-pseudofs-…
jaraco Dec 7, 2025
4ca2bcf
Restore logic where existance and directoriness are checked on realpath.
jaraco Dec 7, 2025
3c79be6
Link GH issue to test.
jaraco Dec 7, 2025
d1d85b9
Extract a function to check the target. Remove the _safe_realpath, no…
jaraco Dec 8, 2025
855aac3
Extract method for replacing sys_path, and isolate realpath usage there.
jaraco Dec 8, 2025
03eae7e
Revert "Extract method for replacing sys_path, and isolate realpath u…
jaraco Dec 8, 2025
6779597
Restore _safe_realpath.
jaraco Dec 8, 2025
d1adfb1
Merge branch 'main' into pdb-realpath-pseudofs-problem
jaraco Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pick target depending on preconditions
  • Loading branch information
@johnslavik
johnslavik committed Dec 7, 2025
commit 70507701b780edd9aa5a7d8b1dc047dd56356766
10 changes: 6 additions & 4 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,15 +183,17 @@ class _ExecutableTarget:

class _ScriptTarget(_ExecutableTarget):
def __init__(self, target):
self._target = os.path.realpath(target)

if not os.path.exists(self._target):
if not os.path.exists(target):
Comment thread
jaraco marked this conversation as resolved.
print(f'Error: {target} does not exist')
sys.exit(1)
if os.path.isdir(self._target):
if os.path.isdir(target):
print(f'Error: {target} is a directory')
sys.exit(1)

# Be careful with realpath to support pseudofilesystems (GH-142315).
realpath = os.path.realpath(target)
self._target = realpath if os.path.exists(realpath) else target

# If safe_path(-P) is not set, sys.path[0] is the directory
# of pdb, and we should replace it with the directory of the script
if not sys.flags.safe_path:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-12-07-02-36-24.gh-issue-142315.02o5E_.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Pdb can run scripts from pseudofiles. Patch by Bartosz Sławecki.
Loading