Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36511: fix -u parameters #14280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

bpo-36511: fix -u parameters #14280

merged 1 commit into from
Jun 21, 2019

Conversation

paulmon
Copy link
Contributor

@paulmon paulmon commented Jun 20, 2019 •
edited by bedevere-bot
Loading

Based on the buildbot log output
-unetwork,decimal,subprocess,urlfetch,tzdata
is being transformed to
-unetwork decimal subprocess urlfetch tzdata

Notice the missing commas. I don't know if this is causing the current failures but it seems incorrect.
Also, I'm not sure why this didn't go in the build master config instead of the .bat file. Maybe it should be moved if this fixes something.

@zooba @zware

https://bugs.python.org/issue36511

@zooba zooba merged commit f8dd77d into python:master Jun 21, 2019
@miss-islington
Copy link
Contributor

Thanks @paulmon for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

zooba pushed a commit to zooba/cpython that referenced this pull request Jun 21, 2019
@paulmon @zooba
bpo-36511: Fix -u parameters for ARM32 tests (pythonGH-14280)
51bdc0c
@bedevere-bot
Copy link

GH-14290 is a backport of this pull request to the 3.8 branch.

@paulmon
Copy link
Contributor Author

paulmon commented Jun 21, 2019 •
edited
Loading

@zooba

It looks like fixing test.bat fixed the test_socket failures. It passed on 3 buildbot builds in a row (2 debug, 1 retail, 2nd retail build is still running). I'm keeping an eye on this one to make sure it's not still timing out sometimes.

There are still failures in test_time and test_strptime

The failures in test_time have the same root cause inside the CRT as the other time bug I worked around (_tznames[] returns empty strings). timemodule.c (line 503) strftime(zone, sizeof(zone), "%Z", &buf); returns "" in zone

All of the tests in test_strptime have a ‘%Z’ in them. Which is the format string which when passed to strftime in timemodule.c that returns an empty string (should print the timezone).

Do you think I should try to workaround all of the %Z failures? Fixing all of the place strftime or strptime is used looks more complicated than fixing time.tznames was.

zooba added a commit that referenced this pull request Jun 21, 2019
@zooba
bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
f3e38ec
@paulmon paulmon deleted the buildbot_worker branch July 17, 2019 20:29
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@paulmon @lisroach
bpo-36511: Fix -u parameters for ARM32 tests (pythonGH-14280)
bef870a
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@paulmon @DinoV
bpo-36511: Fix -u parameters for ARM32 tests (pythonGH-14280)
de9c630
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulmon @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni