Address code review

python · corona10 · Dec 18, 2025 · Dec 16, 2025 · Dec 16, 2025 · Dec 16, 2025
commit 59e32470280b48ca3cd7262f4e21fecf0c539cf2
diff --git a/Include/internal/pycore_opcode_metadata.h b/Include/internal/pycore_opcode_metadata.h
diff --git a/Include/internal/pycore_uop_metadata.h b/Include/internal/pycore_uop_metadata.h
@@ -365,7 +365,7 @@ dummy_func(
         }
 
         op(_POP_TOP_UNICODE, (value --)) {
-            assert(PyUnicode_Check(PyStackRef_AsPyObjectBorrow(value)));
+            assert(PyUnicode_CheckExact(PyStackRef_AsPyObjectBorrow(value)));
             PyStackRef_CLOSE_SPECIALIZED(value, _PyUnicode_ExactDealloc);
         }
 
@@ -753,7 +753,9 @@ dummy_func(
             l = left;
             r = right;
             INPUTS_DEAD();
-            ERROR_IF(res_o == NULL);
+            if (res_o == NULL) {
+                ERROR_NO_POP();
+            }
             res = PyStackRef_FromPyObjectSteal(res_o);
         }
 

diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h
diff --git a/Python/optimizer_cases.c.h b/Python/optimizer_cases.c.h