Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-139922: Tail calling for MSVC (VS 2026) #143068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 11 commits into from
Dec 22, 2025
Merged

GH-139922: Tail calling for MSVC (VS 2026) #143068

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
374874c
rebased + _Py_VectorCallInstrumentation_StackRefSteal
chris-eibl Dec 21, 2025
e0cd0f5
Merge commit '374874c3e6d8c4745a52b3bc22044db607b2c9e7' into msvc-tai…
chris-eibl Dec 21, 2025
7e5555a
try to fix MSVC tail call CI
chris-eibl Dec 22, 2025
a75042a
Alternative to restrict and conditional Py_NO_INLINE for PyMapping_Ge…
chris-eibl Dec 22, 2025
fdfd8a0
make _PyMapping_GetOptionalItem2 private and comment scopes
chris-eibl Dec 22, 2025
058889e
Merge with main because aarch64 jit builds started failing
chris-eibl Dec 22, 2025
c8d051b
Apply suggestions from code review
chris-eibl Dec 22, 2025
ab70524
Update .github/workflows/tail-call.yml
chris-eibl Dec 22, 2025
5c1c240
enable "Emulated Windows Clang (release)"
chris-eibl Dec 22, 2025
a04824f
Merge remote-tracking branch 'upstream/main' into msvc-tail-call-new
chris-eibl Dec 22, 2025
da1adaf
revert to cmd but keep Hugo's other changes
chris-eibl Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
revert to cmd but keep Hugo's other changes 
add --no-progress to choco
  • Loading branch information
@chris-eibl
chris-eibl committed Dec 22, 2025
commit da1adaf41e08d367cf6e45e181ebbfd4a065f11c
14 changes: 7 additions & 7 deletions .github/workflows/tail-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ jobs:
- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2022
- target: aarch64-pc-windows-msvc/msvc
architecture: ARM64
runner: windows-2022
# - target: aarch64-pc-windows-msvc/msvc
# architecture: ARM64
# runner: windows-2022
- target: x86_64-apple-darwin/clang
architecture: x86_64
runner: macos-15-intel
Expand All @@ -81,17 +81,17 @@ jobs:

- name: Native Windows MSVC (release)
if: runner.os == 'Windows' && matrix.architecture != 'ARM64'
shell: pwsh
shell: cmd
Comment thread
chris-eibl marked this conversation as resolved.
run: |
choco install visualstudio2026buildtools -y --force --params "--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --locale en-US --passive"
set PATH=C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\MSBuild\Current\bin;%PATH%
choco install visualstudio2026buildtools --no-progress -y --force --params "--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 --locale en-US --passive"
$env:PATH = "C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\MSBuild\Current\bin;$env:PATH"
./PCbuild/build.bat --tail-call-interp -c Release -p ${{ matrix.architecture }} "/p:PlatformToolset=v145"
./PCbuild/rt.bat -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3

# No tests (yet):
- name: Emulated Windows Clang (release)
if: runner.os == 'Windows' && matrix.architecture == 'ARM64'
shell: pwsh
shell: cmd
Comment thread
chris-eibl marked this conversation as resolved.
run: |
choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0
set PlatformToolset=clangcl
Expand Down
Loading