gh-142557: fix UAF in bytearray.__mod__ via re-entrant argument's `…

…__repr__`
python · picnixz · Dec 27, 2025 · Dec 27, 2025 · Dec 27, 2025 · Dec 27, 2025
commit 9baf9c00fc9a18806aa9285235d8b0664f4c9448
diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
@@ -1382,6 +1382,19 @@ def test_bytearray_api(self):
             except OSError:
                 pass
 
+    def test_mod_use_after_free(self):
+        # Prevent UAF in bytearray % (a1, a2) with re-entrant a[12].__repr__.
+        # Regression test for https://github.com/python/cpython/issues/142557.
+        fmt = bytearray(b"%a %a")
+
+        class S:
+            def __repr__(self):
+                fmt.clear()
+                return "E"
+
+        args = (S(), S())
+        self.assertRaises(BufferError, fmt.__mod__, args)
+
     def test_reverse(self):
         b = bytearray(b'hello')
         self.assertEqual(b.reverse(), None)

diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-12-27-12-25-06.gh-issue-142557.KWOc8b.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-12-27-12-25-06.gh-issue-142557.KWOc8b.rst
@@ -0,0 +1,3 @@
+Fix a use-after-free crash in :meth:`bytearray.__mod__` when the
+:meth:`~object.__repr__` method of one of the arguments to format mutates
+the :class:`bytearray`. Patch by Bénédikt Tran.
diff --git a/Objects/bytearrayobject.c b/Objects/bytearrayobject.c
@@ -2837,7 +2837,15 @@ bytearray_mod_lock_held(PyObject *v, PyObject *w)
     _Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED(v);
     if (!PyByteArray_Check(v))
         Py_RETURN_NOTIMPLEMENTED;
-    return _PyBytes_FormatEx(PyByteArray_AS_STRING(v), PyByteArray_GET_SIZE(v), w, 1);
+
+    PyByteArrayObject *self = _PyByteArray_CAST(v);
+    /* Increase exports to prevent bytearray storage from changing during op. */
+    self->ob_exports++;
+    PyObject *res = _PyBytes_FormatEx(
+        PyByteArray_AS_STRING(v), PyByteArray_GET_SIZE(v), w, 1
+    );
+    self->ob_exports--;
+    return res;
 }
 
 static PyObject *