Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-143309: fix UAF in os.execve when the environment is concurrently mutated #143314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
picnixz merged 13 commits into from
Jan 3, 2026
+60 −18
Merged

gh-143309: fix UAF in os.execve when the environment is concurrently mutated #143314

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
243b880
gh-143309: fix UAF in `os.execve` when the environment is concurrentl…
picnixz Dec 31, 2025
be3bd3d
simplify error handling
picnixz Jan 1, 2026
6750191
fix double-free
picnixz Jan 1, 2026
a7a572c
fix tests on Windows
picnixz Jan 1, 2026
6202904
fortify invokation of `assert_python_ok`
picnixz Jan 1, 2026
71e7277
Apply suggestion from @chris-eibl
chris-eibl Jan 1, 2026
e074d33
fix tests
picnixz Jan 1, 2026
5bd7d39
try to fix Windows tests
picnixz Jan 1, 2026
7b6e2db
fix Windows failures (take 2)
picnixz Jan 1, 2026
c944ef8
remove test crashing on Windows
picnixz Jan 1, 2026
fefb95a
update comment
picnixz Jan 1, 2026
de838f5
Update Misc/NEWS.d/next/Library/2025-12-31-20-43-02.gh-issue-143309.c…
picnixz Jan 2, 2026
d8f9c52
Update Lib/test/test_os/test_os.py
picnixz Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix Windows failures (take 2)
  • Loading branch information
@picnixz
picnixz committed Jan 1, 2026
commit 7b6e2db3ce57d795c828d20281511137bab63729
7 changes: 5 additions & 2 deletions Lib/test/test_os/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2666,8 +2666,11 @@ def test_execve_env_concurrent_mutation_with_fspath_windows(self):
code = """
import os, sys

assert list(os.environ.keys()) == ["SYSTEMROOT"]
assert list(os.environ.values()) == [{SYSTEMROOT!r}]
assert "SYSTEMROOT" in os.environ, list(os.environ.keys())
assert os.environ["SYSTEMROOT"] == {SYSTEMROOT!r}, (
repr(os.environ["SYSTEMROOT"]),
repr({SYSTEMROOT!r}),
)

class MyPath:
def __fspath__(self):
Expand Down
Loading