Address review feedback

- Remove AI-generated comments from test - Use skipIf decorator instead of runtime check - Simplify NEWS entry (don't mention private _dlopen)
python · encukou · Feb 24, 2026 · Dec 31, 2025 · Dec 31, 2025 · Jan 1, 2026
commit d8b9ed3686cdb4b9486a16ab0814b8a43fe1567b
diff --git a/Lib/test/test_ctypes/test_loading.py b/Lib/test/test_ctypes/test_loading.py
@@ -107,17 +107,11 @@ def test_load_without_name_and_with_handle(self):
         self.assertIs(handle, lib._handle)
 
     @unittest.skipIf(os.name == "nt", 'POSIX-specific test')
+    @unittest.skipIf(libc_name is None, 'could not find libc')
     def test_load_without_name_and_with_handle_posix(self):
-        # Test that CDLL honors the handle parameter on POSIX systems
-        # This is a regression test for gh-143304
-        if libc_name is None:
-            self.skipTest('could not find libc')
-        # First load a library normally to get a handle
         lib1 = CDLL(libc_name)
         handle = lib1._handle
-        # Now create a new CDLL instance with the same handle
         lib2 = CDLL(name=None, handle=handle)
-        # The handle should be used directly, not ignored
         self.assertIs(handle, lib2._handle)
-        self.assertIs(handle, lib2._handle)
+        self.assertIs(lib2._handle, handle)
-        self.assertIs(handle, lib2._handle)
+        self.assertIs(lib2._handle, handle)
 
     @unittest.skipUnless(os.name == "nt", 'Windows-specific test')

diff --git a/Misc/NEWS.d/next/Library/2026-01-01-05-26-00.gh-issue-143304.Kv7x9Q.rst b/Misc/NEWS.d/next/Library/2026-01-01-05-26-00.gh-issue-143304.Kv7x9Q.rst
@@ -1 +1 @@
-Fix :class:`ctypes.CDLL` to honor the ``handle`` parameter on POSIX systems. The parameter was being ignored, causing the library to always call ``_dlopen()`` even when a valid handle was provided.
+Fix :class:`ctypes.CDLL` to honor the ``handle`` parameter on POSIX systems.
diff --git a/fix_demonstration.py b/fix_demonstration.py
@@ -0,0 +1,51 @@
+# Demonstration of the fix for gh-143304
+# This shows the before and after behavior
+
+print("=" * 60)
+print("BEFORE THE FIX (main branch):")
+print("=" * 60)
+print("""
+def _load_library(self, name, mode, handle, winmode):
+    # ... iOS/tvOS/watchOS .fwork handling ...
+    # ... AIX archive handling ...
+    self._name = name
+    return _dlopen(name, mode)  # ❌ handle parameter is IGNORED!
+""")
+
+print("\n" + "=" * 60)
+print("AFTER THE FIX (our branch):")
+print("=" * 60)
+print("""
+def _load_library(self, name, mode, handle, winmode):
+    # ... iOS/tvOS/watchOS .fwork handling ...
+    # ... AIX archive handling ...
+    self._name = name
+    if handle is not None:      # ✅ Check if handle was provided
+        return handle           # ✅ Use the provided handle
+    return _dlopen(name, mode)  # Only call _dlopen if no handle
+""")
+
+print("\n" + "=" * 60)
+print("COMPARISON WITH WINDOWS VERSION:")
+print("=" * 60)
+print("""
+Windows _load_library (already correct):
+    self._name = name
+    if handle is not None:
+        return handle
+    return _LoadLibrary(self._name, winmode)
+
+POSIX _load_library (now fixed to match):
+    self._name = name
+    if handle is not None:      # ← This was missing!
+        return handle           # ← This was missing!
+    return _dlopen(name, mode)
+""")
+
+print("\n" + "=" * 60)
+print("VERIFICATION:")
+print("=" * 60)
+print("✓ The fix adds 2 lines to the POSIX implementation")
+print("✓ The fix matches the Windows implementation pattern")
+print("✓ The fix allows users to pass an existing handle to CDLL")
+print("✓ The fix prevents unnecessary _dlopen() calls when handle is provided")
diff --git a/test_handle_fix.py b/test_handle_fix.py
@@ -0,0 +1,25 @@
+import ctypes
+import sys
+import os
+
+print(f"OS name: {os.name}")
+print(f"Platform: {sys.platform}")
+
+if os.name == "nt":
+    print("\nTesting Windows WinDLL...")
+    try:
+        # Get a handle from kernel32
+        handle = ctypes.windll.kernel32._handle
+        print(f"Got kernel32 handle: {handle}")
+
+        # Try to create a new WinDLL with that handle
+        print("Creating WinDLL with name=None and handle...")
+        lib = ctypes.WinDLL(name=None, handle=handle)
+        print(f"Success! Created lib with handle: {lib._handle}")
+        print(f"Handles match: {handle == lib._handle}")
+    except Exception as e:
+        print(f"Error: {type(e).__name__}: {e}")
+        import traceback
+        traceback.print_exc()
+else:
+    print("Not on Windows, skipping test")
diff --git a/test_output.txt b/test_output.txt
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		Fix :class:`ctypes.CDLL` to honor the ``handle`` parameter on POSIX systems. The parameter was being ignored, causing the library to always call ``_dlopen()`` even when a valid handle was provided.
		Fix :class:`ctypes.CDLL` to honor the ``handle`` parameter on POSIX systems.