Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-134584: JIT: Remove redundant refcount from STORE_FAST #143336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 7 commits into from
Jan 2, 2026
Merged

gh-134584: JIT: Remove redundant refcount from STORE_FAST #143336

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f22ea64
JIT: Remove redundant refcount for STORE_FAST
Fidget-Spinner Jan 1, 2026
9477098
Add a test
Fidget-Spinner Jan 1, 2026
aad2f80
fix typo
Fidget-Spinner Jan 1, 2026
844cc42
initialize frame values to NULL when args are known
Fidget-Spinner Jan 1, 2026
c481698
address reviews
Fidget-Spinner Jan 1, 2026
37064ec
address test nit
Fidget-Spinner Jan 2, 2026
7b8bc27
Merge remote-tracking branch 'upstream/main' into swap_fast
Fidget-Spinner Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address reviews
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Jan 1, 2026
commit c4816988dfdcae8391cf48ce4f4044a1a102f56f
62 changes: 31 additions & 31 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ def iter_ops(ex):
def get_ops(ex):
return list(iter_ops(ex))

def matching_opnames(ex, name):
return [opname for opname in iter_opnames(ex) if opname == name]
def count_ops(ex, name):
return len([opname for opname in iter_opnames(ex) if opname == name])


@requires_specialization
Expand Down Expand Up @@ -1921,8 +1921,8 @@ def testfunc(n):
self.assertIn("_BINARY_OP_SUBSCR_STR_INT", uops)
self.assertIn("_COMPARE_OP_STR", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP_INT")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP_INT"), 1)

def test_call_type_1_guards_removed(self):
def testfunc(n):
Expand Down Expand Up @@ -2214,7 +2214,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_CALL_BUILTIN_O", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 4)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 4)

def test_call_method_descriptor_o(self):
def testfunc(n):
Expand All @@ -2231,7 +2231,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_CALL_METHOD_DESCRIPTOR_O", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 4)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 4)

def test_get_len_with_const_tuple(self):
def testfunc(n):
Expand Down Expand Up @@ -2558,7 +2558,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_POP_TOP_NOP", uops)
self.assertIn("_PUSH_FRAME", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)
Comment thread
tomasr8 marked this conversation as resolved.

def test_store_fast_refcount_elimination_when_uninitialized(self):
def foo():
Expand All @@ -2578,7 +2578,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_POP_TOP_NOP", uops)
self.assertIn("_PUSH_FRAME", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)


def test_float_op_refcount_elimination(self):
Expand Down Expand Up @@ -2611,7 +2611,7 @@ class C():
uops = get_opnames(ex)

self.assertIn("_LOAD_ATTR_INSTANCE_VALUE", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)
self.assertIn("_POP_TOP_NOP", uops)

def test_load_attr_with_hint(self):
Expand All @@ -2632,7 +2632,7 @@ class C:
uops = get_opnames(ex)

self.assertIn("_LOAD_ATTR_WITH_HINT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)
self.assertIn("_POP_TOP_NOP", uops)

def test_load_addr_slot(self):
Expand All @@ -2651,7 +2651,7 @@ class C:
uops = get_opnames(ex)

self.assertIn("_LOAD_ATTR_SLOT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)
self.assertIn("_POP_TOP_NOP", uops)

def test_int_add_op_refcount_elimination(self):
Expand All @@ -2667,7 +2667,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_BINARY_OP_ADD_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_int_sub_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2682,7 +2682,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_BINARY_OP_SUBTRACT_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_int_mul_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2697,7 +2697,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_BINARY_OP_MULTIPLY_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_int_cmp_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2712,7 +2712,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_COMPARE_OP_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_float_cmp_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2727,7 +2727,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_COMPARE_OP_FLOAT", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_str_cmp_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2742,7 +2742,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_COMPARE_OP_STR", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_unicode_add_op_refcount_elimination(self):
def testfunc(n):
Expand All @@ -2758,7 +2758,7 @@ def testfunc(n):
uops = get_opnames(ex)
self.assertIn("_BINARY_OP_ADD_UNICODE", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_remove_guard_for_slice_list(self):
def f(n):
Expand Down Expand Up @@ -2817,7 +2817,7 @@ class C:
uops = get_opnames(ex)

self.assertIn("_STORE_ATTR_INSTANCE_VALUE", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)
self.assertIn("_POP_TOP_NOP", uops)

def test_store_attr_with_hint(self):
Expand All @@ -2837,7 +2837,7 @@ class C:
uops = get_opnames(ex)

self.assertIn("_STORE_ATTR_WITH_HINT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)
self.assertIn("_POP_TOP_NOP", uops)

def test_store_subscr_int(self):
Expand All @@ -2855,7 +2855,7 @@ def testfunc(n):
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_STORE_SUBSCR_LIST_INT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)
self.assertNotIn("_POP_TOP_INT", uops)
self.assertIn("_POP_TOP_NOP", uops)

Expand Down Expand Up @@ -2892,7 +2892,7 @@ def testfunc(n):
self.assertIsNotNone(ex)
uops = get_opnames(ex)
self.assertIn("_STORE_SUBSCR_DICT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 1)
self.assertIn("_POP_TOP_NOP", uops)

def test_attr_promotion_failure(self):
Expand Down Expand Up @@ -3226,7 +3226,7 @@ def testfunc(n):
assert "_LOAD_CONST_INLINE_BORROW" in uops
assert "_POP_TOP_NOP" in uops
pop_top_count = [opname for opname in ex if opname == "_POP_TOP" ]
len(pop_top_count) <= 2
assert len(pop_top_count) <= 2
"""), PYTHON_JIT="1")
self.assertEqual(result[0].rc, 0, result)

Expand Down Expand Up @@ -3257,8 +3257,8 @@ def testfunc(n):
uops = get_opnames(ex)

self.assertIn("_BINARY_OP_SUBSCR_LIST_INT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP_INT")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP_INT"), 1)
self.assertIn("_POP_TOP_NOP", uops)

def test_binary_subscr_tuple_int(self):
Expand All @@ -3276,8 +3276,8 @@ def testfunc(n):
uops = get_opnames(ex)

self.assertIn("_BINARY_OP_SUBSCR_TUPLE_INT", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 3)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP_INT")), 1)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 3)
self.assertLessEqual(count_ops(ex, "_POP_TOP_INT"), 1)
self.assertIn("_POP_TOP_NOP", uops)

def test_is_op(self):
Expand All @@ -3295,7 +3295,7 @@ def test_is_false(n):

self.assertIn("_IS_OP", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)


def test_is_true(n):
Expand All @@ -3311,7 +3311,7 @@ def test_is_true(n):

self.assertIn("_IS_OP", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)


def test_is_not(n):
Expand All @@ -3328,7 +3328,7 @@ def test_is_not(n):

self.assertIn("_IS_OP", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)


def test_is_none(n):
Expand All @@ -3343,7 +3343,7 @@ def test_is_none(n):

self.assertIn("_IS_OP", uops)
self.assertIn("_POP_TOP_NOP", uops)
self.assertLessEqual(len(matching_opnames(ex, "_POP_TOP")), 2)
self.assertLessEqual(count_ops(ex, "_POP_TOP"), 2)

def test_143026(self):
# https://github.com/python/cpython/issues/143026
Expand Down
Loading