Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-139757: Add BINARY_OP_SUBSCR_USTR_INT #143389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 11 commits into from
Jan 4, 2026
Merged

gh-139757: Add BINARY_OP_SUBSCR_USTR_INT #143389

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15387dc
POC implementation of BINARY_OP_SUBSCR_NCSTR_INT
chris-eibl Jan 3, 2026
b97fe4e
Merge remote-tracking branch 'upstream/main' into substr_cstr_int
chris-eibl Jan 4, 2026
f69803d
BINARY_OP_SUBSCR_NCSTR_INT -> BINARY_OP_SUBSCR_USTR_INT
chris-eibl Jan 4, 2026
f7c0739
Use _POP_TOP_UNICODE
chris-eibl Jan 4, 2026
6ad8076
move _PyLong_IsNonNegativeCompact into specialize
chris-eibl Jan 4, 2026
e7e3f40
Narrow the result type of _BINARY_OP_SUBSCR_USTR_INT to str in the JIT
chris-eibl Jan 4, 2026
c56ca35
add tests
chris-eibl Jan 4, 2026
5685681
blurb it
chris-eibl Jan 4, 2026
00a2bb4
fix DEOPT_IF and INPUTS_DEAD
chris-eibl Jan 4, 2026
d41332e
bump magic number - better safe than sorry
chris-eibl Jan 4, 2026
6956fce
Update Include/internal/pycore_magic_number.h
Fidget-Spinner Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix DEOPT_IF and INPUTS_DEAD
  • Loading branch information
@chris-eibl
chris-eibl committed Jan 4, 2026
commit 00a2bb4a06a0df396e63d4ac464dc721583b17a9
8 changes: 4 additions & 4 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,16 +951,16 @@ dummy_func(

assert(PyLong_CheckExact(sub));
assert(PyUnicode_CheckExact(str));
assert(_PyLong_IsNonNegativeCompact((PyLongObject *)sub));
DEOPT_IF(!_PyLong_IsNonNegativeCompact((PyLongObject*)sub));
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
DEOPT_IF(PyUnicode_GET_LENGTH(str) <= index);
uint8_t c = PyUnicode_1BYTE_DATA(str)[index];
assert(c < 128);
STAT_INC(BINARY_OP, hit);
PyObject *res_o = (PyObject*)&_Py_SINGLETON(strings).ascii[c];
INPUTS_DEAD();
s = str_st;
i = sub_st;
INPUTS_DEAD();
res = PyStackRef_FromPyObjectBorrow(res_o);
}

Expand All @@ -973,17 +973,17 @@ dummy_func(

assert(PyLong_CheckExact(sub));
assert(PyUnicode_CheckExact(str));
assert(_PyLong_IsNonNegativeCompact((PyLongObject *)sub));
DEOPT_IF(!_PyLong_IsNonNegativeCompact((PyLongObject*)sub));
Py_ssize_t index = ((PyLongObject*)sub)->long_value.ob_digit[0];
DEOPT_IF(PyUnicode_GET_LENGTH(str) <= index);
// Specialize for reading an ASCII character from any string:
Py_UCS4 c = PyUnicode_READ_CHAR(str, index);
DEOPT_IF(Py_ARRAY_LENGTH(_Py_SINGLETON(strings).ascii) <= c);
STAT_INC(BINARY_OP, hit);
PyObject *res_o = (PyObject*)&_Py_SINGLETON(strings).ascii[c];
INPUTS_DEAD();
s = str_st;
i = sub_st;
INPUTS_DEAD();
res = PyStackRef_FromPyObjectBorrow(res_o);
}

Expand Down
16 changes: 14 additions & 2 deletions Python/executor_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading