Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-36511: clean up python process before deploy #14431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2019
Merged

bpo-36511: clean up python process before deploy #14431

merged 1 commit into from
Sep 9, 2019

Conversation

paulmon
Copy link
Contributor

@paulmon paulmon commented Jun 27, 2019 •
edited by bedevere-bot
Loading

If the previous buildbot test times out, there will be orphaned python processes that prevent deploy from working. Kill python.exe processes before trying to clean remote test directory

@zooba @zware

https://bugs.python.org/issue36511

zware
zware approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided that the kill command exists :). I may be operating from out of date information, but I thought Windows only offered taskkill /IM python.exe?

@zooba
Copy link
Member

zooba commented Sep 9, 2019

Agreed with Zachary - "kill" isn't a Windows cmd.exe command (it is an alias in PowerShell), and I'm pretty sure you've only got cmd.exe commands at the other end of the SSH connection (since dir /b won't work in PowerShell).

Unless it's a new/extra addition on the buildbot?

@paulmon
Copy link
Contributor Author

paulmon commented Sep 9, 2019 •
edited
Loading

kill.exe is a command on Windows IoT Core which is what the buildbot is running.
There is no taskkill.exe on Windows IoT Core.
I haven't seen this problem occur since I made this PR.
The last time the arm32 worker machine was producing bad results (stack overflow test kept failing)
because it was unhealthy a reboot was required to recover it.

@zware zware added the skip news label Sep 9, 2019
@zware
Copy link
Member

zware commented Sep 9, 2019

Ok, we'll give this a try then.

@zware zware merged commit 55d12ce into python:master Sep 9, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@paulmon @websurfer5
bpo-36511: clean up python process before deploy on ARM Windows build…
5de360e 
…bots (pythonGH-14431)
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulmon @zooba @zware @the-knights-who-say-ni @bedevere-bot