Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-116738: Align bz2 unused_data getter to lzma implementation #144351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 1 commit into from
Apr 11, 2026
+10 −7
Merged

gh-116738: Align bz2 unused_data getter to lzma implementation #144351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Align bz2 unused_data getter to lzma
  • Loading branch information
@yoney
yoney committed Jan 27, 2026
commit 43dc39b488c99723f7f1fd07c999d3c8567d4462
17 changes: 10 additions & 7 deletions Modules/_bz2module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,10 +524,12 @@ decompress(BZ2Decompressor *d, char *data, size_t len, Py_ssize_t max_length)
if (d->eof) {
FT_ATOMIC_STORE_CHAR_RELAXED(d->needs_input, 0);
if (d->bzs_avail_in_real > 0) {
Py_XSETREF(d->unused_data,
PyBytes_FromStringAndSize(bzs->next_in, d->bzs_avail_in_real));
if (d->unused_data == NULL)
PyObject *unused_data = PyBytes_FromStringAndSize(
bzs->next_in, d->bzs_avail_in_real);
if (unused_data == NULL) {
goto error;
}
Py_XSETREF(d->unused_data, unused_data);
}
}
else if (d->bzs_avail_in_real == 0) {
Expand Down Expand Up @@ -687,12 +689,13 @@ static PyObject *
BZ2Decompressor_unused_data_get(PyObject *op, void *Py_UNUSED(ignored))
{
BZ2Decompressor *self = _BZ2Decompressor_CAST(op);
if (!FT_ATOMIC_LOAD_CHAR_RELAXED(self->eof)) {
return Py_GetConstant(Py_CONSTANT_EMPTY_BYTES);
}
PyMutex_Lock(&self->mutex);
PyObject *result = Py_XNewRef(self->unused_data);
assert(self->unused_data != NULL);
PyObject *result = Py_NewRef(self->unused_data);
PyMutex_Unlock(&self->mutex);
if (result == NULL) {
PyErr_SetString(PyExc_AttributeError, "unused_data");
}
return result;
}

Expand Down
Loading