Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-143535: Dispatch on the second argument if generic method is instance-bindable #144615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ambv merged 21 commits into from
Feb 24, 2026
+78 −2
Merged

gh-143535: Dispatch on the second argument if generic method is instance-bindable #144615

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
5479e0f
Dispatch on the second argument if generic method is instance-bindable
johnslavik Feb 8, 2026
3455cd9
Only cut off first argument if method becomes bound
johnslavik Feb 9, 2026
1142577
Cutoff on function, not method!
johnslavik Feb 9, 2026
d05750f
Cut first argument after the fact!
johnslavik Feb 9, 2026
b81977b
Fix missing import
johnslavik Feb 9, 2026
f6afaec
Fix formatting
johnslavik Feb 9, 2026
9dac097
Intentionally don't handle an edge case
johnslavik Feb 9, 2026
354721b
Add tests
johnslavik Feb 9, 2026
d80e5d1
Fix formatting
johnslavik Feb 9, 2026
97f23cd
Add news entry
johnslavik Feb 9, 2026
12cd97a
Rewrite comments
johnslavik Feb 9, 2026
1a24e43
Inline argument cutoff condition
johnslavik Feb 9, 2026
615c284
Empty commit to unstuck GitHub processing recent push
johnslavik Feb 9, 2026
ab7d78c
Add correct GitHub references
johnslavik Feb 9, 2026
dd804d2
Make the implementation more debuggable
johnslavik Feb 10, 2026
85c318d
Fix `staticmethod` bug
johnslavik Feb 15, 2026
21dcd02
Assign the boolean directly
johnslavik Feb 16, 2026
4c1cfd7
Simplify method dispatch
johnslavik Feb 16, 2026
e3538f5
More meaningful variable names
johnslavik Feb 16, 2026
0878b55
Reiterate on the code
johnslavik Feb 16, 2026
373deb0
Write a "What's New" entry
johnslavik Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify method dispatch
  • Loading branch information
@johnslavik
johnslavik committed Feb 16, 2026
commit 4c1cfd7047a09d1cb1e998b6eb9ebb3a793f1385
6 changes: 2 additions & 4 deletions Lib/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,10 +1093,8 @@ def __call__(self, /, *args, **kwargs):
'singledispatchmethod method')
raise TypeError(f'{funcname} requires at least '
'1 positional argument')
if self._skip_bound_arg:
method = self._dispatch(args[1].__class__)
else:
method = self._dispatch(args[0].__class__)
index = 1 if self._skip_bound_arg else 0
method = self._dispatch(args[index].__class__)

if hasattr(method, "__get__"):
# If the method is a descriptor, it might be necessary
Expand Down
Loading