[3.14] gh-145376: Fix various reference leaks (GH-145377)

(cherry picked from commit bd13cc0) Co-authored-by: Jelle Zijlstra <[email protected]>
python · encukou · Mar 10, 2026 · Mar 3, 2026 · Mar 9, 2026 · 9db908037bec79c7d5b3e16e22146d19294d1af0
commit 9db908037bec79c7d5b3e16e22146d19294d1af0
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-02-28-16-46-17.gh-issue-145376.lG5u1a.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-02-28-16-46-17.gh-issue-145376.lG5u1a.rst
@@ -0,0 +1 @@
+Fix reference leaks in various unusual error scenarios.
@@ -509,6 +509,7 @@ pymain_run_interactive_hook(int *exitcode)
     }
 
     if (PySys_Audit("cpython.run_interactivehook", "O", hook) < 0) {
+        Py_DECREF(hook);
         goto error;
     }
 

@@ -609,6 +609,7 @@ check_missing___main___attr(PyObject *exc)
     // Get the error message.
     PyObject *args = PyException_GetArgs(exc);
     if (args == NULL || args == Py_None || PyObject_Size(args) < 1) {
+        Py_XDECREF(args);
         assert(!PyErr_Occurred());
         return 0;
     }

@@ -1151,6 +1151,7 @@ _PyErr_Display(PyObject *file, PyObject *unused, PyObject *value, PyObject *tb)
         "traceback",
         "_print_exception_bltin");
     if (print_exception_fn == NULL || !PyCallable_Check(print_exception_fn)) {
+        Py_XDECREF(print_exception_fn);
         goto fallback;
     }
 

@@ -1759,7 +1759,7 @@ sys_getwindowsversion_impl(PyObject *module)
     PyObject *realVersion = _sys_getwindowsversion_from_kernel32();
     if (!realVersion) {
         if (!PyErr_ExceptionMatches(PyExc_WindowsError)) {
-            return NULL;
+            goto error;
         }
 
         PyErr_Clear();
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix reference leaks in various unusual error scenarios.
-Original file line number
+Diff line change
@@ Expand Up / @@ -509,6 +509,7 @@ pymain_run_interactive_hook(int *exitcode) @@
         }
         if (PySys_Audit("cpython.run_interactivehook", "O", hook) < 0) {
+            Py_DECREF(hook);
             goto error;
         }
@@ Expand Down @@