Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-146302: make Py_IsInitialized() thread-safe and reflect true init completion #146303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 10 commits into from
Apr 11, 2026
Merged

gh-146302: make Py_IsInitialized() thread-safe and reflect true init completion #146303

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1eda370
gh-146302: make Py_IsInitialized() thread-safe and reflect true init …
gpshead Mar 22, 2026
efeae3b
Improve comment wording in pycore_runtime.h accessors
gpshead Mar 22, 2026
3e1eedd
PySys_AddAuditHook: check initialized, not core_initialized
gpshead Mar 22, 2026
59f51a2
Add regression test: Py_IsInitialized() must be false during site import
gpshead Mar 22, 2026
2e3aa7e
Remove unnecessary putenv("PYTHONMALLOC=") from test
gpshead Mar 22, 2026
ba28b37
Address review: use wrapper functions instead of low-level accessors
gpshead Mar 22, 2026
abae231
alphabetical includes, ack that other APIs are used in the comment
gpshead Mar 22, 2026
01df0a2
Address review: use seq-cst atomics for initialized flags
gpshead Mar 23, 2026
ee2d0be
_testembed.test_init_main assert not init per review
gpshead Apr 11, 2026
aec5131
Merge branch 'main' into gh-146302-py-isinitialized-thread-safe
gpshead Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PySys_AddAuditHook: check initialized, not core_initialized 
The docs say audit hooks are notified "after runtime initialization".
With the flag move, initialized=0 throughout init (including site
import), so hooks are correctly not invoked during any init phase.
Using core_initialized would have expanded the invocation window
beyond the original behavior.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
  • Loading branch information
@gpshead @claude
gpshead and claude committed Mar 22, 2026
commit 3e1eedd470b7b2dd70fecdc6861d7027ca1eb27a
4 changes: 2 additions & 2 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Data members:
#include "pycore_pymath.h" // _PY_SHORT_FLOAT_REPR
#include "pycore_pymem.h" // _PyMem_DefaultRawFree()
#include "pycore_pystate.h" // _PyThreadState_GET()
#include "pycore_runtime.h" // _PyRuntimeState_GetCoreInitialized()
#include "pycore_runtime.h" // _PyRuntimeState_GetInitialized()
Comment thread
gpshead marked this conversation as resolved.
Outdated
#include "pycore_pystats.h" // _Py_PrintSpecializationStats()
#include "pycore_structseq.h" // _PyStructSequence_InitBuiltinWithFlags()
#include "pycore_sysmodule.h" // export _PySys_GetSizeOf()
Expand Down Expand Up @@ -472,7 +472,7 @@ PySys_AddAuditHook(Py_AuditHookFunction hook, void *userData)
PySys_AddAuditHook() can be called before Python is initialized. */
_PyRuntimeState *runtime = &_PyRuntime;
PyThreadState *tstate;
if (_PyRuntimeState_GetCoreInitialized(runtime)) {
if (_PyRuntimeState_GetInitialized(runtime)) {
tstate = _PyThreadState_GET();
}
else {
Expand Down
Loading