Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-126910: Verify that JIT stencils preserve frame pointer #146524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 11 commits into from
Mar 27, 2026
Merged

gh-126910: Verify that JIT stencils preserve frame pointer #146524

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fae87b9
Verify that JIT stencils preserve frame pointer
Fidget-Spinner Mar 27, 2026
776e109
Update _optimizers.py
Fidget-Spinner Mar 27, 2026
8ad1774
Fix lint
Fidget-Spinner Mar 27, 2026
8c9fb56
more linting
Fidget-Spinner Mar 27, 2026
a66c8cd
Merge remote-tracking branch 'upstream/main' into fp_verifier
Fidget-Spinner Mar 27, 2026
c3eaa2a
Merge remote-tracking branch 'upstream/main' into fp_verifier
Fidget-Spinner Mar 27, 2026
bde6c5b
Try a fix
Fidget-Spinner Mar 27, 2026
3e1199e
PEP 7
Fidget-Spinner Mar 27, 2026
743cc6a
Revert "PEP 7"
Fidget-Spinner Mar 27, 2026
d7a2d30
Revert "Try a fix"
Fidget-Spinner Mar 27, 2026
108ea06
Apply Brandt's fix
Fidget-Spinner Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update _optimizers.py
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Mar 27, 2026
commit 776e109d0b43ecdabdf83b8f70641aa5e5f565e8
8 changes: 4 additions & 4 deletions Tools/jit/_optimizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class Optimizer:
_re_small_const_1 = _RE_NEVER_MATCH
_re_small_const_2 = _RE_NEVER_MATCH
const_reloc = "<Not supported>"
_frame_pointer_prologue: typing.ClassVar[re.Pattern[str]] = _RE_NEVER_MATCH
_frame_pointer_modify: typing.ClassVar[re.Pattern[str]] = _RE_NEVER_MATCH

def __post_init__(self) -> None:
# Split the code into a linked list of basic blocks. A basic block is an
Expand Down Expand Up @@ -561,7 +561,7 @@ def _validate(self):
continue
for inst in block.instructions:
if self.frame_pointers:
assert self._frame_pointer_prologue.match(inst.text) is None, "Frame pointer should not be modified"
assert self._frame_pointer_modify.match(inst.text) is None, "Frame pointer should not be modified"

def run(self) -> None:
"""Run this optimizer."""
Expand Down Expand Up @@ -606,7 +606,7 @@ class OptimizerAArch64(Optimizer): # pylint: disable = too-few-public-methods
r"\s*(?P<instruction>ldr)\s+.*(?P<value>_JIT_OP(ARG|ERAND(0|1))_(16|32)).*"
)
const_reloc = "CUSTOM_AARCH64_CONST"
_frame_pointer_prologue = re.compile(r"\s*stp\s+x29.*")
_frame_pointer_modify = re.compile(r"\s*stp\s+x29.*")

def _get_reg(self, inst: Instruction) -> str:
_, rest = inst.text.split(inst.name)
Expand Down Expand Up @@ -662,4 +662,4 @@ class OptimizerX86(Optimizer): # pylint: disable = too-few-public-methods
_re_jump = re.compile(r"\s*jmp\s+(?P<target>[\w.]+)")
# https://www.felixcloutier.com/x86/ret
_re_return = re.compile(r"\s*retq?\b")
_frame_pointer_prologue = re.compile(r"\s*pushq\s+%rbp.*")
_frame_pointer_modify = re.compile(r"\s*movq?\s+%(\w+),\s+%rbp.*")
Loading