Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-146636: Improve ABI/feature selection, add new header for it #148302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 11 commits into from
Apr 23, 2026
Merged

gh-146636: Improve ABI/feature selection, add new header for it #148302

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1116e1e
gh-146636: abi3t: Test that Python.h avoids checking Py_GIL_DISABLED
encukou Apr 5, 2026
4581298
Move ABI/feature selection macros to their own header
encukou Apr 9, 2026
e1b7500
Update check for <intrin.h>
encukou Apr 9, 2026
247bd46
Typo
encukou Apr 9, 2026
7835449
Move Py_BUILD_CORE undefines, and include exports.h directly from Pyt…
encukou Apr 9, 2026
2ad80d8
Comments
encukou Apr 9, 2026
7c9d920
Apply suggestions from code review
encukou Apr 10, 2026
38950b8
Merge in the main branch
encukou Apr 17, 2026
c477a14
Don't poison on clang
encukou Apr 17, 2026
05e7c90
Error out if _Py_OPAQUE_PYOBJECT is defined by user
encukou Apr 17, 2026
72b1637
Require version in Py_LIMITED_API & Py_TARGET_ABI3T
encukou Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Victor Stinner <[email protected]>
  • Loading branch information
@encukou @vstinner
encukou and vstinner authored Apr 10, 2026
commit 7c9d92006e8d24fda1f5a249bcc3918779d52e7a
5 changes: 3 additions & 2 deletions Include/pyabi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@
# define Py_GIL_DISABLED
# endif
# if defined(_Py_IS_TESTCEXT)
Copy link
Copy Markdown
Member

@vstinner vstinner Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may move #ifdef __GNUC__ here:

Suggested change
# if defined(_Py_IS_TESTCEXT)
# if defined(_Py_IS_TESTCEXT) && defined(__GNUC__)

Copy link
Copy Markdown
Member Author

@encukou encukou Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This subtle style detail is intentional: I'm inviting #elifs for other compilers.

// When compiling for abi3t, contents of Python.h should not depend
// When compiling for abi3t, contents of Python.h should not depend
// on Py_GIL_DISABLED.
// We ask GCC to error if it sees the macro from this point on.
// Since users are free to the macro, and there's no way to undo the
// poisoning at the end of Python.h, we only do this in a test module.
// poisoning at the end of Python.h, we only do this in a test module
// (test_cext).
# ifdef __GNUC__
# undef Py_GIL_DISABLED
# pragma GCC poison Py_GIL_DISABLED
Expand Down
Loading