Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-131798: Split _CHECK_AND_ALLOCATE_OBJECT into smaller uops #148433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 7 commits into from
Apr 12, 2026
Merged

gh-131798: Split _CHECK_AND_ALLOCATE_OBJECT into smaller uops #148433

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c745a0
initial commit to split the uops
Sacul0457 Apr 12, 2026
d976e47
revert test
Sacul0457 Apr 12, 2026
c72c139
remove empty line
Sacul0457 Apr 12, 2026
7885033
Partially address reviews
Sacul0457 Apr 12, 2026
13e2608
handle probable and non-probable cases
Fidget-Spinner Apr 12, 2026
fc0c169
lint
Fidget-Spinner Apr 12, 2026
a459c25
add tests
Fidget-Spinner Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Partially address reviews 
Co-authored-by: Hai Zhu <[email protected]>
  • Loading branch information
@Sacul0457 @cocolato
Sacul0457 and cocolato authored Apr 12, 2026
commit 788503304a07fe104d63da20a42774805d2608f5
5 changes: 3 additions & 2 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,7 +1077,7 @@ dummy_func(void) {
// then we know this __init__ is definitely the same one as in the cache.
// We can promote callable to a known constant. This does not need a
// type watcher, as we do not remove this _CHECK_AND_ALLOCATE_OBJECT guard.
if (sym_is_not_null(self_or_null) && sym_matches_type(callable, &PyType_Type)) {
if (sym_is_null(self_or_null) && sym_matches_type(callable, &PyType_Type)) {
ADD_OP(_NOP, 0, 0);
}
PyHeapTypeObject *cls = (PyHeapTypeObject *)probable_callable;
Expand All @@ -1100,7 +1100,8 @@ dummy_func(void) {
PyType_Watch(TYPE_WATCHER_ID, (PyObject *)type);
_Py_BloomFilter_Add(dependencies, type);
}
}
}
self_or_null = sym_new_not_null(ctx);
}
}

Expand Down
Loading