Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-148242: Partial restoration of the historical behavior of defaultdict, without losing thread safety #148881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Changaco wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-148242: Partial restoration of the historical behavior of defaultdict, without losing thread safety #148881

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a5f522
restore historical behavior of `defaultdict`
Changaco Apr 12, 2026
0985fd1
simplify the `defdict_missing` function
Changaco Apr 12, 2026
03d0d11
defaultdict: remove __missing__, add __getitem__
Changaco Apr 12, 2026
da97340
add NEWS entry
Changaco Apr 21, 2026
a86ddb4
fix Sphinx warnings
Changaco Apr 22, 2026
9f641e9
fix still broken ref in NEWS entry
Changaco Apr 22, 2026
20139ff
update `Doc/tools/removed-ids.txt`
Changaco Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplify the defdict_missing function
  • Loading branch information
@Changaco
Changaco committed Apr 22, 2026
commit 0985fd10099a7434359197927e03bbaae60e7cd6
6 changes: 1 addition & 5 deletions Modules/_collectionsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2237,11 +2237,7 @@ defdict_missing(PyObject *op, PyObject *key)
PyObject *value;
if (factory == NULL || factory == Py_None) {
/* XXX Call dict.__missing__(key) */
PyObject *tup;
tup = PyTuple_Pack(1, key);
if (!tup) return NULL;
PyErr_SetObject(PyExc_KeyError, tup);
Py_DECREF(tup);
_PyErr_SetKeyError(key);
return NULL;
}
value = _PyObject_CallNoArgs(factory);
Expand Down