Clarify docs for error case of PyDict_GetItemRef - #149506
Merged
kumaraditya303 merged 3 commits intoMay 8, 2026
Merged
Conversation
ngoldbaum
force-pushed
the
fix-dict-getitemref-error-docs
branch
from
May 7, 2026 19:21
e873771 to
de69c83
Compare
Documentation build overview
|
ngoldbaum
force-pushed
the
fix-dict-getitemref-error-docs
branch
from
May 7, 2026 20:42
de69c83 to
2abbc1e
Compare
ngoldbaum
commented
May 7, 2026
kumaraditya303
approved these changes
May 8, 2026
kumaraditya303
enabled auto-merge (squash)
May 8, 2026 10:44
|
Thanks @ngoldbaum for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-149546 is a backport of this pull request to the 3.15 branch. |
|
GH-149547 is a backport of this pull request to the 3.14 branch. |
|
Thanks @ngoldbaum for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
GH-149548 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
May 8, 2026
…49506) (#149548) docs: Clarify docs for error case of `PyDict_GetItemRef` (GH-149506) (cherry picked from commit 3565d31) Co-authored-by: Nathan Goldbaum <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
May 8, 2026
…49506) (#149546) docs: Clarify docs for error case of `PyDict_GetItemRef` (GH-149506) (cherry picked from commit 3565d31) Co-authored-by: Nathan Goldbaum <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
May 8, 2026
…49506) (#149547) docs: Clarify docs for error case of `PyDict_GetItemRef` (GH-149506) (cherry picked from commit 3565d31) Co-authored-by: Nathan Goldbaum <[email protected]>
Member
|
It wasn't documented to leave it as an implementation detail. But if you consider that it's useful, yeah, why not documenting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I manually inspected and asked Claude to inspect the implementation, and I think all error paths set
*resultto NULL.See numpy/numpy#31256 (comment) for where this came up for me today.