Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-34880: assert statement misbehavior if AssertionError is shadowed #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 25, 2019
Merged

bpo-34880: assert statement misbehavior if AssertionError is shadowed #15073

merged 7 commits into from
Aug 25, 2019

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Aug 1, 2019 •
edited by bedevere-bot
Loading

The assert statement was not working properly if the AssertionError
exception was being shadowed.

https://bugs.python.org/issue34880

serhiy-storchaka
serhiy-storchaka reviewed Aug 1, 2019
View reviewed changes
@markshannon
Copy link
Member

I'd like to keep any new bytecodes as simple as possible. The simplest I can think of is a LOAD_ASSERTION_ERROR which would be equivalent to LOAD_CONSTANT AssertionError.
It would also keep the changes to the compiler to a minimum.

@serhiy-storchaka
Copy link
Member

I concur with @markshannon. There is no benefit from implementing it as a single bytecode: it is neither performance critical nor should be atomical. Using LOAD_ASSERTION_ERROR would simplify the compiler and the bytecode interpreter a bit.

@ZackerySpytz
Copy link
Contributor Author

Thanks for all of the comments. I have implemented LOAD_ASSERTION_ERROR. Please take a look.

ZackerySpytz
ZackerySpytz commented Aug 13, 2019
View reviewed changes
qigangxu
qigangxu reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@qigangxu qigangxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better for "{" at the end of the previous line.

@ZackerySpytz
Copy link
Contributor Author

@qigangxu All of the code in this PR follows the PEP 7 and PEP 8 style guides, so I'm not sure what the purpose of your comment is.

serhiy-storchaka
serhiy-storchaka approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it needs to wait until #15320 be merged.

@qigangxu
Copy link
Contributor

@qigangxu All of the code in this PR follows the PEP 7 and PEP 8 style guides, so I'm not sure what the purpose of your comment is.

Sorry, no code location information was provided last comment. The issue is in line 3327 of Python/compile.c.

@serhiy-storchaka serhiy-storchaka merged commit ce6a070 into python:master Aug 25, 2019
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Aug 25, 2019
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@ZackerySpytz @lisroach
bpo-34880: Add the LOAD_ASSERTION_ERROR opcode. (pythonGH-15073)
69f6113 
Fix assert statement misbehavior if AssertionError is shadowed.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@ZackerySpytz @DinoV
bpo-34880: Add the LOAD_ASSERTION_ERROR opcode. (pythonGH-15073)
69c6f00 
Fix assert statement misbehavior if AssertionError is shadowed.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@ZackerySpytz @websurfer5
bpo-34880: Add the LOAD_ASSERTION_ERROR opcode. (pythonGH-15073)
126050b 
Fix assert statement misbehavior if AssertionError is shadowed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qigangxu qigangxu qigangxu left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @markshannon @serhiy-storchaka @qigangxu @the-knights-who-say-ni @bedevere-bot