gh-149079: Optimize sorting in unicodedata.normalize() - #150782
Merged
encukou merged 1 commit intoJun 15, 2026
Conversation
Sort the Py_UCS4 buffer instead of PyUnicodeObject. This allows to avoid the use of PyUnicode_READ() and PyUnicode_WRITE().
Member
Author
Baseline: 100 loops, best of 5: 3.76 msec per loop Baseline: 100 loops, best of 5: 3.99 msec per loop |
Contributor
|
@serhiy-storchaka On your benchmark I can improve from 3.75 ms to 2.0 ms by using a more efficient search in |
Member
Author
Looks interesting. But this is a different issue, not directly related to #149079. Can you open a new issue? |
Contributor
eendebakpt
approved these changes
Jun 12, 2026
eendebakpt
left a comment
Contributor
There was a problem hiding this comment.
I benchmarked the PR (rebased onto main first) and found a 10% to 20% speedup on the benchmarks.
Member
|
Thank you! |
philthompson10
pushed a commit
to philthompson10/cpython
that referenced
this pull request
Jun 17, 2026
…H-150782) Sort the Py_UCS4 buffer instead of PyUnicodeObject. This allows to avoid the use of PyUnicode_READ() and PyUnicode_WRITE().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort the Py_UCS4 buffer instead of PyUnicodeObject. This allows to avoid the use of PyUnicode_READ() and PyUnicode_WRITE().
unicodedata.normalize("NFC")canonical ordering #149079