bpo-37876: Tests for ROT-13 codec (GH-15314) #15314

zeth · 2019-08-16T16:02:18Z

The Rot-13 codec is for educational use but does not have unit tests,
dragging down test coverage. This adds a few very simple tests.

https://bugs.python.org/issue37876

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests.

the-knights-who-say-ni · 2019-08-16T16:02:21Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

zooba · 2019-09-09T14:50:12Z

Thanks! Sorry for taking so long to see and review your PR.

miss-islington · 2019-09-09T14:50:40Z

Thanks @zeth for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests. (cherry picked from commit b3b48c8) Co-authored-by: Zeth <[email protected]>

bedevere-bot · 2019-09-09T14:50:53Z

GH-15786 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2019-09-09T15:08:39Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows7 SP1 3.x has failed when building commit b3b48c8.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/40/builds/3009) and take a look at the build logs.
Check if the failure is related to this commit (b3b48c8) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/40/builds/3009

Failed tests:

test_asyncio

Failed subtests:

test_huge_content_recvinto - test.test_asyncio.test_sock_lowlevel.SelectEventLoopTests
test_huge_content_recvinto - test.test_asyncio.test_sock_lowlevel.ProactorEventLoopTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

385 tests OK.

10 slowest tests:

test_multiprocessing_spawn: 2 min 26 sec
test_tools: 2 min 6 sec
test_tokenize: 1 min 49 sec
test_venv: 1 min 48 sec
test_concurrent_futures: 1 min 48 sec
test_mmap: 1 min 46 sec
test_io: 1 min 39 sec
test_lib2to3: 1 min 27 sec
test_asyncio: 1 min 18 sec
test_socket: 57 sec 240 ms

1 test failed:
test_asyncio

33 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_tix test_tk test_ttk_guionly
test_wait3 test_wait4 test_xxtestfuzz test_zipfile64

1 re-run test:
test_asyncio

Total duration: 12 min 33 sec

Click to see traceback logs

Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\proactor_events.py", line 768, in _loop_self_reading
    f.result()  # may raise
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 808, in _poll
    value = callback(transferred, key, ov)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 457, in finish_recv
    raise ConnectionResetError(*exc.args)
ConnectionResetError: [WinError 995] The I/O operation has been aborted because of either a thread exit or an application request
k


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 66, in _cancel_overlapped
    self._ov.cancel()
OSError: [WinError 6] The handle is invalid


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_sock_lowlevel.py", line 225, in test_huge_content_recvinto
    self.loop.run_until_complete(
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\base_events.py", line 608, in run_until_complete
    return future.result()
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_sock_lowlevel.py", line 211, in _basetest_huge_content_recvinto
    nbytes = await self.loop.sock_recv_into(sock, buf)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\proactor_events.py", line 696, in sock_recv_into
    return await self._proactor.recv_into(sock, buf)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 808, in _poll
    value = callback(transferred, key, ov)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 480, in finish_recv
    raise ConnectionResetError(*exc.args)
ConnectionResetError: [WinError 64] The specified network name is no longer available


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_sock_lowlevel.py", line 225, in test_huge_content_recvinto
    self.loop.run_until_complete(
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\base_events.py", line 608, in run_until_complete
    return future.result()
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\test\test_asyncio\test_sock_lowlevel.py", line 211, in _basetest_huge_content_recvinto
    nbytes = await self.loop.sock_recv_into(sock, buf)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\selector_events.py", line 400, in sock_recv_into
    return await fut
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\selector_events.py", line 409, in _sock_recv_into
    nbytes = sock.recv_into(buf)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 66, in _cancel_overlapped
    self._ov.cancel()
OSError: [WinError 6] The handle is invalid
k


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 453, in finish_recv
    return ov.getresult()
OSError: [WinError 995] The I/O operation has been aborted because of either a thread exit or an application request


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 476, in finish_recv
    return ov.getresult()
OSError: [WinError 64] The specified network name is no longer available


Traceback (most recent call last):
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\proactor_events.py", line 768, in _loop_self_reading
    f.result()  # may raise
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 808, in _poll
    value = callback(transferred, key, ov)
  File "C:\buildbot.python.org\3.x.kloth-win64\build\lib\asyncio\windows_events.py", line 457, in finish_recv
    raise ConnectionResetError(*exc.args)
ConnectionResetError: [WinError 995] The I/O operation has been aborted because of either a thread exit or an application request

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests. (cherry picked from commit b3b48c8) Co-authored-by: Zeth <[email protected]>

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests.

bpo-NN: Tests for ROT-13 codec (GH-NNNN)

b7adda4

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests.

the-knights-who-say-ni added the CLA not signed label Aug 16, 2019

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 16, 2019

zeth changed the title ~~bpo-NNNN: Tests for ROT-13 codec (GH-NNNN)~~ bpo-37876: Tests for ROT-13 codec (GH-NNNN) Aug 16, 2019

zeth changed the title ~~bpo-37876: Tests for ROT-13 codec (GH-NNNN)~~ bpo-37876: Tests for ROT-13 codec (GH-15314) Aug 16, 2019

📜🤖 Added by blurb_it.

f14618c

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Aug 16, 2019

epicfaace approved these changes Aug 23, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Aug 23, 2019

zooba added the needs backport to 3.8 label Sep 9, 2019

zooba merged commit b3b48c8 into python:master Sep 9, 2019

bedevere-bot removed the awaiting core review label Sep 9, 2019

bedevere-bot removed the needs backport to 3.8 label Sep 9, 2019

websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020

bpo-37876: Tests for ROT-13 codec (pythonGH-15314)

f0900f7

The Rot-13 codec is for educational use but does not have unit tests, dragging down test coverage. This adds a few very simple tests.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-37876: Tests for ROT-13 codec (GH-15314) #15314

bpo-37876: Tests for ROT-13 codec (GH-15314) #15314

Uh oh!

zeth commented Aug 16, 2019 •

edited by bedevere-bot

Loading

Uh oh!

the-knights-who-say-ni commented Aug 16, 2019

Uh oh!

zooba commented Sep 9, 2019

Uh oh!

miss-islington commented Sep 9, 2019

Uh oh!

bedevere-bot commented Sep 9, 2019

Uh oh!

bedevere-bot commented Sep 9, 2019

Uh oh!

Uh oh!

Uh oh!

bpo-37876: Tests for ROT-13 codec (GH-15314) #15314

bpo-37876: Tests for ROT-13 codec (GH-15314) #15314

Uh oh!

Conversation

zeth commented Aug 16, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Aug 16, 2019

Uh oh!

zooba commented Sep 9, 2019

Uh oh!

miss-islington commented Sep 9, 2019

Uh oh!

bedevere-bot commented Sep 9, 2019

Uh oh!

bedevere-bot commented Sep 9, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

zeth commented Aug 16, 2019 •

edited by bedevere-bot

Loading