Codestin Search App

serhiy-storchaka · 2026-08-01T19:25:51Z

None is not a valid value for any of the context attributes. The C implementation silently ignored it, because it shared the code with the Context constructor, where None means "not specified". The pure Python implementation always rejected it.

Issue: decimal.localcontext() ignores None keyword arguments in the C implementation #155051

None is not a valid value for any of the context attributes. The C implementation silently ignored it, because it shared the code with the Context constructor, where None means "not specified". The pure Python implementation always rejected it. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>

skirpichev · 2026-08-02T00:31:53Z

+    prec: object = NULL
+    rounding: object = NULL
+    Emin: object = NULL
+    Emax: object = NULL
+    capitals: object = NULL
+    clamp: object = NULL
+    flags: object = NULL
+    traps: object = NULL


As in #155047, this is not rendered well by signature().

We already use @text_signature "($module, /, ctx=None, **kwargs)" for this method. And the Python implementation has the same signature.

Yes, there is no regression. Though, I think in future we could use here explicit arguments with a sentinel.

# Conflicts: # Modules/_decimal/_decimal.c # Modules/_decimal/clinic/_decimal.c.h

bedevere-bot · 2026-08-02T08:21:15Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO 3.x (tier-1) has failed when building commit 96ebb20.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1620/builds/4131) and take a look at the build logs.
Check if the failure is related to this commit (96ebb20) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1620/builds/4131

Failed tests:

test_venv

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\test_venv.py", line 90, in tearDown
    rmtree(self.env_dir)
    ~~~~~~^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 508, in rmtree
    _rmtree(path)
    ~~~~~~~^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 440, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 436, in _rmtree_inner
    _waitfor(_rmtree_inner, fullname, waitall=True)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 439, in _rmtree_inner
    _force_run(fullname, os.unlink, fullname)
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\__init__.py", line 224, in _force_run
    return func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_c3hbjmmo\\tmp596rn58_\\Scripts\\python.exe'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\test_venv.py", line 90, in tearDown
    rmtree(self.env_dir)
    ~~~~~~^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 508, in rmtree
    _rmtree(path)
    ~~~~~~~^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 440, in _rmtree
    _waitfor(_rmtree_inner, path, waitall=True)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 436, in _rmtree_inner
    _waitfor(_rmtree_inner, fullname, waitall=True)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\os_helper.py", line 439, in _rmtree_inner
    _force_run(fullname, os.unlink, fullname)
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\__init__.py", line 224, in _force_run
    return func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_fd8wl30k\\tmpp_f14nel\\Scripts\\python.exe'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\__init__.py", line 213, in _force_run
    return func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_fd8wl30k\\tmpp_f14nel\\Scripts\\python.exe'


Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10.pgo\build\Lib\test\support\__init__.py", line 213, in _force_run
    return func(*args)
PermissionError: [WinError 5] Access is denied: 'D:\\temp\\test_python_c3hbjmmo\\tmp596rn58_\\Scripts\\python.exe'

…t() (pythonGH-155054) None is not a valid value for any of the context attributes. The C implementation silently ignored it, because it shared the code with the Context constructor, where None means "not specified". The pure Python implementation always rejected it. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>

bedevere-app Bot mentioned this pull request Aug 1, 2026

decimal.localcontext() ignores None keyword arguments in the C implementation #155051

Closed

bedevere-app Bot added the awaiting core review label Aug 1, 2026

serhiy-storchaka requested a review from skirpichev August 1, 2026 19:26

skirpichev approved these changes Aug 2, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into localcontext-none

772eba8

# Conflicts: # Modules/_decimal/_decimal.c # Modules/_decimal/clinic/_decimal.c.h

serhiy-storchaka enabled auto-merge (squash) August 2, 2026 06:39

serhiy-storchaka merged commit 96ebb20 into python:main Aug 2, 2026
53 checks passed

bedevere-app Bot removed the awaiting core review label Aug 2, 2026

serhiy-storchaka deleted the localcontext-none branch August 27, 2026 12:35

Navigation Menu

Uh oh!

Uh oh!

gh-155051: Reject None keyword arguments in decimal.localcontext() - #155054

gh-155051: Reject None keyword arguments in decimal.localcontext()#155054
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:localcontext-none

serhiy-storchaka commented Aug 1, 2026

Uh oh!

skirpichev Aug 2, 2026

Uh oh!

serhiy-storchaka Aug 2, 2026

Uh oh!

skirpichev Aug 2, 2026

Uh oh!

Uh oh!

bedevere-bot commented Aug 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

serhiy-storchaka commented Aug 1, 2026

Uh oh!

skirpichev Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

skirpichev Aug 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Aug 2, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants