gh-155218: Generate the option group flags in a stable order - #155219
Merged
Conversation
They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
August 5, 2026 07:58
serhiy-storchaka
enabled auto-merge (squash)
August 5, 2026 08:10
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-155224 is a backport of this pull request to the 3.14 branch. |
|
GH-155225 is a backport of this pull request to the 3.13 branch. |
|
GH-155226 is a backport of this pull request to the 3.15 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 5, 2026
…H-155219) (GH-155225) They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. (cherry picked from commit 7aec160) Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Aug 5, 2026
…H-155219) (GH-155224) They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. (cherry picked from commit 7aec160) Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
deadlovelll
pushed a commit
to deadlovelll/cpython
that referenced
this pull request
Aug 5, 2026
…rder (pythonGH-155219) (pythonGH-155224) They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. (cherry picked from commit 7aec160) Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
mbeijen
pushed a commit
to mbeijen/cpython
that referenced
this pull request
Aug 14, 2026
…ythonGH-155219) They were emitted in the iteration order of a set of group identifiers. The identifiers of the groups before the required parameters are small negative integers, -1 and -2 have the same hash, so their order depended on the size of Py_hash_t, and the code generated on a 32-bit platform differed from the checked in one. They are now emitted in the order of the parameters. Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flags of the optional groups were emitted in the iteration order of a set of group identifiers.
The identifiers of the groups before the required parameters are small negative integers, and
hash(-1) == hash(-2) == -2, so the order of these colliding keys depends on the size ofPy_hash_t.A 32-bit build therefore generated
Modules/clinic/_cursesmodule.c.h(addch(),addstr()and 7 other functions) differently from the checked in file.The flags are now emitted in the order of the parameters.