[3.13] gh-155752: Do not crash when GenericAlias parameters change during substitution (GH-155761) - #155772
Merged
Merged
Conversation
…ing substitution (pythonGH-155761) An alias argument can gain __typing_subst__ after __parameters__ has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments. (cherry picked from commit c0006fa) Co-authored-by: Darius Houle <[email protected]>
miss-islington
requested review from
AlexWaygood and
JelleZijlstra
as code owners
August 14, 2026 05:14
|
All commit authors signed the Contributor License Agreement. |
This was referenced Aug 14, 2026
Closed
JelleZijlstra
approved these changes
Aug 15, 2026
Member
|
Approved by @JelleZijlstra who merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alias argument can gain typing_subst after parameters has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments.
(cherry picked from commit c0006fa)
Co-authored-by: Darius Houle [email protected]