gh-44376: Write missing namespace declarations in xml.dom.minidom - #156674
Merged
serhiy-storchaka merged 3 commits intoSep 13, 2026
Conversation
Element.writexml() now emits the xmlns declarations needed to serialize the namespaces of the element and its attributes, if they are not already declared for an ancestor. A prefix is invented for a namespaced attribute without a prefix, because attributes cannot use the default namespace. The document is not modified by the serialization. The namespaces in scope are passed down the recursion as a keyword-only argument. They are passed only to the standard implementation of writexml(); an overridden method is called with the documented signature and computes them by walking the ancestors of the element.
Documentation build overview
79 files changed ·
|
A prefix is only invented if no prefix in scope is bound to the namespace of the attribute. The reverse mapping is built only when such attribute is encountered, so there is no cost in the common case. The counter of invented prefixes is not reset for every attribute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Element.writexml()now writes thexmlnsdeclarations needed to serialize the namespaces of the element and its attributes, if they are not already declared for an ancestor. A prefix is invented for a namespaced attribute without a prefix, because attributes cannot use the default namespace. The document is not modified by the serialization.The namespaces in scope are passed down the recursion as a keyword-only argument. They are passed only to the standard implementation of
writexml(); an overridden method is called with the documented signature, and computes them by walking the ancestors of the element.