-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
gh-124697: Represent inlined comprehensions as subscopes in the symbol table #156819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iritkatriel
wants to merge
21
commits into
python:main
Choose a base branch
from
iritkatriel:subscope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3245fd7
gh-124697: Represent inlined comprehensions as subscopes in the symbo…
iritkatriel 8dfe966
gh-124697: Add NEWS entry for inlined comprehension symbol tables
iritkatriel 97ace7d
gh-124697: Add What's New entry for inlined comprehension symbol tables
iritkatriel 21ab5dd
simpligy logic and edit docs
iritkatriel 045913c
redundant check
iritkatriel 0c2ad7e
rename helper and use it in more places
iritkatriel a459371
Merge branch 'main' into subscope
iritkatriel 3f7b483
finalize nested against enclosing listcomp
iritkatriel 9d9ebfc
do not splice
iritkatriel bee5d57
fix error handling in push/pop_inlined_comprehension_state
iritkatriel 0a13f59
do not remove free variables from comprehension scope
iritkatriel 28c532b
Merge branch 'main' into subscope
iritkatriel f4ad426
fix test
iritkatriel ef2a6da
fix stale comment
iritkatriel 8b37711
make the symtable honest about __class__ etc
iritkatriel ce7433e
no more climbing in _PyST_GetSymbol - symbol table is honest now
iritkatriel 48f9865
Merge branch 'main' into subscope
iritkatriel 3515cc0
remove DEF_COMP_CELL
iritkatriel ea23c17
deduplicate frame locals
iritkatriel 045091d
Merge branch 'main' into subscope
iritkatriel 5216591
add test
iritkatriel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could we add
.. versionadded:: 3.16to this member? The enclosing enum is documented as introduced in 3.13, so the new member's availability is otherwise unclear.