You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, LLVM’s AArch64 Mach-O linker optimisation hints prevent the JIT optimiser from folding adrp/ldr constant loads into movz. These hints are actually unused because stencils are not directly passed to the Mach-O linker.
This PR disables the linker hints on macOS Aarch64 with -aarch64-enable-collect-loh=false.
E.g. the stencil for _LOAD_SMALL_INT_r01 on macOS currently looks something like this:
Overall, this reduces the size of all stencils on macOS by 4.5%:
Metric
Before
After
Reduction
Machine code
56,340 bytes
55,468 bytes
872 bytes (1.55%)
Instructions
14,085
13,867
218 instructions
Stencil data
3,632 bytes
1,784 bytes
1,848 bytes (50.88%)
Combined
59,972 bytes
57,252 bytes
2,720 bytes (4.54%)
I ran the pyperformance suite before and after on a Apple M5 Pro which suggests a geometric mean improvement of 0.57% and up to 7.3% faster on scimark_sparse_mat_mult.
Expand for full benchmarking results
Benchmarks and code size analysis was run by GPT 5.6 Sol. Code changes are authored by myself.
I realised too late that work on the JIT is currently paused. I'm still opening the PR since #148501 is labeled as a bug, but feel free to ignore it until there's an official decision on the PEP by the steering council.
A follow up to this would be to recognise the @GOTPAGE/@GOTPAGEOFF Darwin syntax similar to what's done for the :got:/:got_l12: ELF syntax so patch_aarch64_33rx can deal with it.
A follow up to this would be to recognise the @GOTPAGE/@GOTPAGEOFF Darwin syntax similar to what's done for the :got:/:got_l12: ELF syntax so patch_aarch64_33rx can deal with it.
Thanks for the PR. I've verified it on my machine and I can see the stencil change.
The way I see it, this is though an optimisation and not a bugfix hence we need to wait the SC decision on the future of the JIT.
A follow up to this would be to recognise the @GOTPAGE/@GOTPAGEOFF Darwin syntax similar to what's done for the :got:/:got_l12: ELF syntax so patch_aarch64_33rx can deal with it.
Can you create a new issue for that?
Yes, will do so soon. I have a pretty easy patch that fixes this. Will make an issue and PR once/if JIT development resumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, LLVM’s AArch64 Mach-O linker optimisation hints prevent the JIT optimiser from folding
adrp/ldrconstant loads intomovz. These hints are actually unused because stencils are not directly passed to the Mach-O linker.This PR disables the linker hints on macOS Aarch64 with
-aarch64-enable-collect-loh=false.E.g. the stencil for
_LOAD_SMALL_INT_r01on macOS currently looks something like this:After this PR, the linker optimisation hints are removed and the JIT optimiser can correctly fold
adrp/ldrconstant loads.Overall, this reduces the size of all stencils on macOS by 4.5%:
I ran the pyperformance suite before and after on a Apple M5 Pro which suggests a geometric mean improvement of 0.57% and up to 7.3% faster on
scimark_sparse_mat_mult.Expand for full benchmarking results
Benchmarks and code size analysis was run by GPT 5.6 Sol. Code changes are authored by myself.
I realised too late that work on the JIT is currently paused. I'm still opening the PR since #148501 is labeled as a bug, but feel free to ignore it until there's an official decision on the PEP by the steering council.
A follow up to this would be to recognise the
@GOTPAGE/@GOTPAGEOFFDarwin syntax similar to what's done for the:got:/:got_l12:ELF syntax sopatch_aarch64_33rxcan deal with it.