Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-157368: Fix clang-cl version in sys.version on Windows - #157369

Merged
zware merged 4 commits into
python:mainfrom
chris-eibl:fix_clang_version
Sep 13, 2026
Merged

gh-157368: Fix clang-cl version in sys.version on Windows#157369
zware merged 4 commits into
python:mainfrom
chris-eibl:fix_clang_version

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Sep 12, 2026

Copy link
Copy Markdown
Member

@chris-eibl
chris-eibl requested a review from a team as a code owner September 12, 2026 17:02
@python-cla-bot

python-cla-bot Bot commented Sep 12, 2026

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@chris-eibl chris-eibl changed the title gh-57368: Fix clang-cl version in sys.version on Windows gh-157368: Fix clang-cl version in sys.version on Windows Sep 12, 2026
@chris-eibl

This comment was marked as outdated.

@chris-eibl

This comment was marked as outdated.

@bedevere-bot

This comment was marked as outdated.

@chris-eibl

This comment was marked as outdated.

@bedevere-bot

This comment was marked as outdated.

@chris-eibl

Copy link
Copy Markdown
Member Author

!buildbot Windows

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @chris-eibl for commit 672a4f7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157369%2Fmerge

The command will test the builders whose names match following regular expression: Windows

The builders matched are:

  • AMD64 Windows PGO Tailcall PR
  • AMD64 Windows11 Non-Debug PR
  • AMD64 Windows Server 2025 Refleaks PR
  • AMD64 Windows Server 2025 Clang PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Windows PGO NoGIL Tailcall PR
  • ARM64 Windows PR
  • ARM64 Windows Non-Debug PR
  • AMD64 Windows10 PR
  • AMD64 Windows PGO PR
  • AMD64 Windows PGO NoGIL PR

Comment thread Misc/NEWS.d/next/Library/2026-09-12-18-59-21.gh-issue-157368.2DirHP.rst Outdated
Comment thread PC/pyconfig.h Outdated
@zware

zware commented Sep 12, 2026

Copy link
Copy Markdown
Member

!buildbot Windows.*Clang

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit a97eec8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F157369%2Fmerge

The command will test the builders whose names match following regular expression: Windows.*Clang

The builders matched are:

  • AMD64 Windows Server 2025 Clang PR

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware
zware merged commit 0ba7be9 into python:main Sep 13, 2026
102 of 104 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Unsupported platforms Sep 13, 2026
@zware zware added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 13, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Thanks @chris-eibl for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.14

@miss-islington-app

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.15

@miss-islington-app

Copy link
Copy Markdown

Sorry, @chris-eibl and @zware, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0ba7be9a18e8b03af1c046d676f71be9208e06d4 3.13

@zware zware removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 13, 2026
@chris-eibl

Copy link
Copy Markdown
Member Author

Yeah, some things have changed, but it's very easy to manual backport. Will do 3.15 and 3.14 in the upcoming days,.

3.13 if deemed reasonable - but that was before my engangement wrt clang so I have no idea about the status there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.15 pre-release feature fixes, bugs and security fixes OS-unsupported

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants