Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[3.15] gh-90304: Fix IDLE startup failure with a broken font (GH-152419) #157395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miss-islington wants to merge 1 commit into
base: 3.15
Choose a base branch
from
+20 −1
Open

[3.15] gh-90304: Fix IDLE startup failure with a broken font (GH-152419) #157395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Lib/idlelib/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,9 @@ def set_width(self):
# http://www.tcl.tk/man/tcl8.6/TkCmd/text.htm#M21
zero_char_width = \
Font(text, font=text.cget('font')).measure('0')
self.width = pixel_width // zero_char_width
# Some fonts report a zero width for '0' (gh-90304).
self.width = (pixel_width // zero_char_width if zero_char_width
else text.tk.getint(text.cget('width')))

def new_callback(self, event):
dirname, basename = self.io.defaultfilename()
Expand Down
13 changes: 13 additions & 0 deletions Lib/idlelib/idle_test/test_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from idlelib import editor
import unittest
from collections import namedtuple
from unittest import mock
from test.support import requires
from tkinter import Tk, Text

Expand Down Expand Up @@ -30,6 +31,18 @@ def test_init(self):
self.assertEqual(e.root, self.root)
e._close()

def test_set_width_zero_char_width(self):
# A zero-width '0' must not raise ZeroDivisionError (gh-90304).
e = Editor(root=self.root)
try:
with mock.patch.object(editor, 'Font') as MockFont:
MockFont.return_value.measure.return_value = 0
e.set_width()
self.assertEqual(e.width,
e.text.tk.getint(e.text.cget('width')))
finally:
e._close()


class GetLineIndentTest(unittest.TestCase):
def test_empty_lines(self):
Expand Down
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/IDLE/2026-06-27-17-27-21.gh-issue-90304.464d22.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Prevent IDLE from failing to start when a font reports a zero width for
the ``'0'`` character. Such a broken font caused a
:exc:`ZeroDivisionError`; the editor now falls back to the configured
width.
Loading