gh-157418: Correct the IocpProactor recvfrom_into parameter name - #157422
Open
lpyu001 wants to merge 1 commit into
Open
gh-157418: Correct the IocpProactor recvfrom_into parameter name#157422lpyu001 wants to merge 1 commit into
lpyu001 wants to merge 1 commit into
Conversation
lpyu001
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
September 13, 2026 12:38
Member
|
That's a breaking change strictly speaking. If we are not sure about how people are calling the APIs, we should be more careful. |
Member
|
Note that socket.recvfrom_into expects a flags not a number of bytes as its last parameter so I don't know what would be correct here (it's surprising that we don't have a flag anymore actually). |
Member
|
to be clear: I acknowledge this is a bug but I don't know if changing the parameter name is safe without a warning or whatever. Can you check the call sites and browse OSS repos? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IocpProactor.recvfrom_into()misnames its receive-size parameter asflags#157418