gh-153568: Factor shared prefixes in expression rules - #157437
Open
pablogsal wants to merge 1 commit into
Open
Conversation
pablogsal
requested review from
Eclips4,
lysnikolaou and
tomasr8
as code owners
September 13, 2026 14:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several expression rules start by parsing the same thing for each choice. For
a - b, the parser tries the+alternative first, then goes back and getsaagain to try-. The cache saves us from parsingafrom scratch, but we still pay for the extra rule call and cache lookup.This puts the shared part before the choice: get the left operand once, then check which operator follows. It does the same for tuples, boolean expressions, comparisons and powers. Parse the first expression once, then look for the optional part that follows it. When there is nothing more to match, return the expression we already have.
On my machine, this makes parsing the full standard library and ten repositories about 4.7% faster overall.
The table compares this change against
mainata60343ed17, using release builds without PGO or LTO. The timings include tokenization, building the AST and cleanup, without compiling bytecode or running the files.Part of #153568.