Fixed bpo-29565: Corrected ctypes passing of large structs by value on Windows AMD64. #168
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code and test to check that when a structure passed by value is large enough to need to be passed by reference, a copy of the original structure is passed. The callee updates the passed-in value, and the test verifies that the caller's copy is unchanged. A similar change was also added to the test added for bpo-20160 (that test was passing, but the changes should guard against regressions).
zooba
approved these changes
Feb 19, 2017
This was referenced Feb 21, 2017
vsajip
added a commit
that referenced
this pull request
Feb 22, 2017
vsajip
added a commit
that referenced
this pull request
Feb 22, 2017
vstinner
added a commit
that referenced
this pull request
Aug 2, 2018
…ows AMD64 (GH-168) (GH-8625) Fixed bpo-29565: Corrected ctypes passing of large structs by value. Added code and test to check that when a structure passed by value is large enough to need to be passed by reference, a copy of the original structure is passed. The callee updates the passed-in value, and the test verifies that the caller's copy is unchanged. A similar change was also added to the test added for bpo-20160 (that test was passing, but the changes should guard against regressions). (cherry picked from commit a86339b)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Aug 16, 2018
… modules Many extension modules were created by Cython versions before commit 037bcf0 and were compiled with regular C-Python. These modules call PyEval_EvalFrameEx() with a broken frame object. This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Aug 16, 2018
… modules Many extension modules were created by Cython versions before commit 037bcf0 and were compiled with regular C-Python. These modules call PyEval_EvalFrameEx() with a broken frame object. This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Aug 18, 2018
… modules Add a test case for a pathological situation.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Aug 18, 2018
… modules Add a test case for a pathological situation.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 1, 2018
… modules Add another test case for a pathological situation.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 3, 2018
… modules Add another test case for a pathological situation.
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 11, 2018
… modules (python#170) Many extension modules were created by Cython versions before commit 037bcf0 and were compiled with regular C-Python. These modules call PyEval_EvalFrameEx() with a broken frame object. This commit add code to recover a broken frame in PyEval_EvalFrameEx(). (cherry picked from commit f9094d2)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 14, 2018
… modules (python#170) Many extension modules were created by Cython versions before commit 037bcf0 and were compiled with regular C-Python. These modules call PyEval_EvalFrameEx() with a broken frame object. This commit add code to recover a broken frame in PyEval_EvalFrameEx().
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Feb 18, 2019
… modules (python#169) Many extension modules were created by Cython versions before commit 037bcf0 and were compiled with regular C-Python. These modules call PyEval_EvalFrameEx() with a broken frame object. This commit add code to recover a broken frame in PyEval_EvalFrameEx().
isidentical
added a commit
to isidentical/cpython
that referenced
this pull request
Oct 15, 2021
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code and test to check that when a structure passed by value
is large enough to need to be passed by reference, a copy of the
original structure is passed. The callee updates the passed-in value,
and the test verifies that the caller's copy is unchanged. A similar
change was also added to the test added for bpo-20160 (that test was
passing, but the changes should guard against regressions).
Thanks to Eryk Sun for the patch.