Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-39009: Fix typo in test__locale #17544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 9, 2019
Merged

bpo-39009: Fix typo in test__locale #17544

merged 6 commits into from
Dec 9, 2019

Conversation

timgates42
Copy link
Contributor

@timgates42 timgates42 commented Dec 9, 2019 •
edited by miss-islington
Loading

There is a small typo in Lib/test/test__locale.py.
Should read thousands rather than thousauds.

https://bugs.python.org/issue39009

Automerge-Triggered-By: @pablogsal

@timgates42
bpo-39002: Fix simple typo. (GH-17517)
dad7af3 
There is a small typo in Lib/test/test_statistics.py.
Should read `translation` rather than `tranlation`.
@timgates42 timgates42 changed the title bpo-39009: Fix simple typo: thousauds -> thousands bpo-39009: Fix simple typo: thousauds -> thousands (GH-17544) Dec 9, 2019
@timgates42
bpo-39009: Fix simple typo. (GH-17544)
172e10f 
There is a small typo in Lib/test/test__locale.py.
Should read `thousands` rather than `thousauds`.
pablogsal
pablogsal requested changes Dec 9, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

pablogsal
pablogsal approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @timgates42 for the contribution! 🚀

@pablogsal pablogsal changed the title bpo-39009: Fix simple typo: thousauds -> thousands (GH-17544) bpo-39009: Fix typo in test__locale Dec 9, 2019
@pablogsal pablogsal self-assigned this Dec 9, 2019
@miss-islington
Copy link
Contributor

@timgates42: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Contributor

@timgates42: Status check is done, and it's a failure ❌ .

@timgates42
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

@pablogsal pablogsal merged commit 2ad7651 into python:master Dec 9, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@timgates42 @shihai1991
bpo-39009: Fix typo in test__locale (pythonGH-17544)
a3b2a86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timgates42 @bedevere-bot @miss-islington @pablogsal @the-knights-who-say-ni