Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@hauntsaninja

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Hello, it's my first time contributing to CPython!

Apologies if something is incorrect. make patchcheck complained about not having updating Misc/ACKS, although this is a trivial change, so sort of confused about that. Hopefully it'll recognise my CLA signature soon :-)

Thanks for contributing this. However, I don't think there is anything to fix. The argument is positional only (hence the / after it), so its name is purely indicative. Here, bytes_object points to the kind of object that is accepted. By renaming it to data, that information is removed.

I'm rejecting this PR.

Hello @pitrou , thanks for reviewing!
I don't see a / for positional-only, all I see is a * for the remaining arguments being keyword-only. Note that the asterisk is escaped with a backslash in the .rst which could be a possible source of confusion?
As far as I can tell, the argument is not positional-only in pickle.rst on master (.. function:: loads(bytes_object, \*, fix_imports=True, encoding="ASCII", errors="strict", buffers=None)), the rendered documentation at https://docs.python.org/3/library/pickle.html#pickle.loads or the behaviour at runtime:

>>> sys.version
'3.7.6 (default, Dec 30 2019, 19:38:26) \n[Clang 11.0.0 (clang-1100.0.33.16)]'
>>> inspect.signature(pickle.loads)
<Signature (data, *, fix_imports=True, encoding='ASCII', errors='strict')>

If you feel bytes_object is a better name than data, maybe we could actually document the argument as positional-only, and leave the fact that it is positional-or-keyword as undocumented, (or change the implementation to use the name bytes_object).

Hi @hauntsaninja, you're right, it seems I confused the \ with a /. Sorry for that, and I'm reopening the PR.

Gentle bump :-)

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@pitrou: please review the changes made to this pull request.

Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

Sorry @hauntsaninja, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 289842ae820f99908d3a345f1f3b6d4e5b4b97fc 3.8

Thank you @hauntsaninja !

Sorry, @hauntsaninja, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 289842ae820f99908d3a345f1f3b6d4e5b4b97fc 3.7

GH-19843 is a backport of this pull request to the 3.8 branch.

GH-19844 is a backport of this pull request to the 3.7 branch.