Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-39702: Relax grammar restrictions on decorators (PEP 614). #18570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 13 commits into from
Mar 3, 2020
Merged

bpo-39702: Relax grammar restrictions on decorators (PEP 614). #18570

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a994a39
Allow decorators to be any valid expression.
brandtbucher Feb 7, 2020
c60225d
Fix assert.
brandtbucher Feb 17, 2020
7b13502
Catch up with master.
brandtbucher Feb 17, 2020
c08cba5
Add grammar tests.
brandtbucher Feb 17, 2020
d5e4089
Add tests to test_decorators.py.
brandtbucher Feb 19, 2020
86309d6
Add (and reorganize) new decorator tests.
brandtbucher Feb 19, 2020
409095a
Add parser tests.
brandtbucher Feb 20, 2020
02ee14c
Add two more parser tests.
brandtbucher Feb 20, 2020
3d61c24
Add more tests.
brandtbucher Feb 20, 2020
7af6376
Add one more parser test.
brandtbucher Feb 20, 2020
e38477d
Add NEWS entry.
brandtbucher Feb 20, 2020
93936f2
Add comment.
brandtbucher Feb 20, 2020
6305f8b
Fix tiny copy-paste artifact.
brandtbucher Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more tests.
  • Loading branch information
@brandtbucher
brandtbucher committed Feb 20, 2020
commit 3d61c247d3bf8f1c6ae2b2743067eb7fc0a29105
7 changes: 5 additions & 2 deletions Lib/test/test_decorators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def double(x):
def test_errors(self):

# Test SyntaxErrors:
for stmt in ("x, y", "x = y", "pass", "import sys"):
for stmt in ("x,", "x, y", "x = y", "pass", "import sys"):
compile(stmt, "test", "exec") # Sanity check.
with self.assertRaises(SyntaxError):
compile(f"@{stmt}\ndef f(): pass", "test", "exec")
Expand All @@ -177,7 +177,10 @@ def unimp(func):
self.assertRaises(exc, eval, code, context)

def test_expressions(self):
for expr in ("(x, y)", "x := y", "(x := y)", "x @y", "(x @ y)"):
for expr in (
"(x,)", "(x, y)", "x := y", "(x := y)", "x @y", "(x @ y)", "x[0]",
"w[x].y.z", "w + x - (y + z)", "x(y)()(z)", "[w, x, y][z]", "x.y",
):
compile(f"@{expr}\ndef f(): pass", "test", "exec")

def test_double(self):
Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_grammar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,8 @@ def f(x): pass
def f(x): pass
@null(null)(null)
def f(x): pass
@[null][0].__call__.__call__
def f(x): pass

# test closures with a variety of opargs
closure = 1
Expand Down Expand Up @@ -1543,6 +1545,8 @@ class J: pass
class K: pass
@class_decorator(class_decorator)(class_decorator)
class L: pass
@[class_decorator][0].__call__.__call__
class L: pass

def test_dictcomps(self):
# dictorsetmaker: ( (test ':' test (comp_for |
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ def test_function_defs(self):
"def f(): pass")
self.check_suite("@w @(x @y) @(z)\n"
"def f(): pass")
self.check_suite("@w[x].y.z\n"
"def f(): pass")

# keyword-only arguments
self.check_suite("def f(*, a): pass")
Expand Down