Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-39826: add getConnection() hook to logging HTTPHandler #18745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vsajip merged 4 commits into from
Mar 4, 2020
Merged

bpo-39826: add getConnection() hook to logging HTTPHandler #18745

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
775e8f8
make it easy to extend HTTPHandler with custom connection. solves iss…
Mar 2, 2020
4256365
make it easy to extend HTTPHandler with custom connection. solves iss…
l0rb Mar 2, 2020
0cc2490
Merge branch 'master' of github.com:l0rb/cpython
l0rb Mar 2, 2020
94b52e3
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make it easy to extend HTTPHandler with custom connection. solves iss… 
…ue 39826
  • Loading branch information
lorb committed Mar 2, 2020
commit 775e8f85ad4cecb78d55b293ed406cdd46d86443
21 changes: 16 additions & 5 deletions Lib/logging/handlers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,19 +1173,30 @@ def mapLogRecord(self, record):
"""
return record.__dict__

def getConnection(self, host, secure):
"""
get a HTTP[S]Connection.
Override when a custom connection is required, for example if
there is a proxy.
"""
import http.client
if secure:
connection = http.client.HTTPSConnection(host, context=self.context)
else:
connection = http.client.HTTPConnection(host)
return connection

def emit(self, record):
"""
Emit a record.
Send the record to the Web server as a percent-encoded dictionary
"""
try:
import http.client, urllib.parse
import urllib.parse
host = self.host
if self.secure:
h = http.client.HTTPSConnection(host, context=self.context)
else:
h = http.client.HTTPConnection(host)
h = self.getConnection(host, self.secure)
url = self.url
data = urllib.parse.urlencode(self.mapLogRecord(record))
if self.method == "GET":
Expand Down