Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-84353: fix old zip filename corruption, emit cp437 when possible; utf-8 with the flag otherwise #19335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

yudilevi2
Copy link

@yudilevi2 yudilevi2 commented Apr 3, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@nergall2

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

@yudilevi2, please sign the CLA as per @the-knights-who-say-ni bot's message.

@yudilevi2
Copy link
Author

@csabella done

@csabella
Copy link
Contributor

@yudilevi2, also please make this PR against master instead of the 3.8 branch. Typically, changes are made against master and then we have a bot that backports the change to the other releases, if applicable. Thanks!

@csabella
Copy link
Contributor

@yudilevi2, the bot (and I) cannot find a bug tracker profile that matches your github name. Can you check it using this link? Also, please see my comment about the base branch for the change. Thanks!

@yudilevi2
Copy link
Author

@yudilevi2, the bot (and I) cannot find a bug tracker profile that matches your github name. Can you check it using this link? Also, please see my comment about the base branch for the change. Thanks!

Sorry, had multiple github accounts and things got messed up - I updated my profile with the correct github user name now.

@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Apr 21, 2023

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@gpshead gpshead changed the title bpo-40172: fixed old zip filename corruption gh-84353: fix old zip filename corruption, emit cp437 when possible; utf-8 with the flag otherwise May 9, 2023
@gpshead
Copy link
Member

gpshead commented May 10, 2023

this PR needs to be re-created by someone against the main branch.

@gpshead gpshead closed this May 10, 2023
@arhadthedev
Copy link
Member

@gpshead gh-104347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants