Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-40334: Fix errors in parse_string.c with old compilers #19666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

bpo-40334: Fix errors in parse_string.c with old compilers #19666

merged 1 commit into from
Apr 22, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 22, 2020 •
edited by bedevere-bot
Loading

@pablogsal pablogsal self-assigned this Apr 22, 2020
@pablogsal
Copy link
Member Author

This fixes this buildbot errors:

https://buildbot.python.org/all/#/builders/6/builds/824/steps/5/logs/stdio

/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_seq_locations’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:278:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(seq); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:278:5: note: use option -std=c99 or -std=gnu99 to compile your code
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_arguments’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:21: error: redefinition of ‘i’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:21: note: previous definition of ‘i’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:28: error: redefinition of ‘l’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:325:28: note: previous definition of ‘l’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->posonlyargs); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:21: error: redefinition of ‘i’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:21: note: previous definition of ‘i’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:28: error: redefinition of ‘l’
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:330:28: note: previous definition of ‘l’ was here
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->args); i < l; i++) {
                            ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:339:5: error: ‘for’ loop initial declarations are only allowed in C99 mode
     for (Py_ssize_t i = 0, l = asdl_seq_LEN(args->kwonlyargs); i < l; i++) {
     ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_shift_children_locations’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:387:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.ListComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:394:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.SetComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:402:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.DictComp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:29: error: redefinition of ‘i’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:29: note: previous definition of ‘i’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:36: error: redefinition of ‘l’
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:409:36: note: previous definition of ‘l’ was here
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.GeneratorExp.generators); i < l; i++) {
                                    ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:430:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (Py_ssize_t i = 0, l = asdl_seq_LEN(n->v.Call.keywords); i < l; i++) {
             ^
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c: In function ‘fstring_fix_expr_location’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Parser/pegen/parse_string.c:521:13: error: ‘for’ loop initial declarations are only allowed in C99 mode
             for (char* p = parent_str; p < substr; p++) {
             ^

@pablogsal pablogsal mentioned this pull request Apr 22, 2020
Merged
@pablogsal pablogsal merged commit 458004b into python:master Apr 22, 2020
@pablogsal pablogsal deleted the fix_buildbot_errors branch April 22, 2020 23:13
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 3192787 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pablogsal pablogsal

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @bedevere-bot @the-knights-who-say-ni