Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-40334: Add tests/test_peg_generator to the install files target #19723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 26, 2020

We forgot to add the test/test_peg_generator folder to LIBSUBDIRS in the Makefile and the windows files.

https://bugs.python.org/issue40334

@pablogsal pablogsal force-pushed the bpo-40334-makefile branch from 1fb311b to e3a152e Compare April 26, 2020 22:49
@pablogsal pablogsal self-assigned this Apr 27, 2020
@pablogsal pablogsal force-pushed the bpo-40334-makefile branch 2 times, most recently from 18d00da to fb1d7a1 Compare April 27, 2020 00:44
@pablogsal pablogsal requested a review from a team as a code owner April 27, 2020 00:44
@pablogsal pablogsal force-pushed the bpo-40334-makefile branch 2 times, most recently from 114dc73 to f41a09c Compare April 27, 2020 00:49
@pablogsal pablogsal force-pushed the bpo-40334-makefile branch from f41a09c to ef9d933 Compare April 27, 2020 00:50
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. (Please update the commit message to explain what else you did to the Windows build file.)

@pablogsal pablogsal changed the title bpo-40334: Add tests/test_peg_generator to the install files target in the Makefile bpo-40334: Add tests/test_peg_generator to the install files target Apr 27, 2020
@pablogsal pablogsal merged commit 4044c84 into python:master Apr 27, 2020
@pablogsal pablogsal deleted the bpo-40334-makefile branch April 27, 2020 10:18
@bedevere-bot

This comment has been minimized.

@pablogsal
Copy link
Member Author

The buildbot failure is unrelated to this PR:

1 test altered the execution environment:
test_concurrent_futures

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Apr 27, 2020
* 'master' of github.com:python/cpython: (2949 commits)
  Add files in tests/test_peg_generator to the install target lists (pythonGH-19723)
  bpo-40398: Fix typing.get_args() for special generic aliases. (pythonGH-19720)
  bpo-40348: Fix typos in the programming FAQ (pythonGH-19729)
  bpo-38387: Formally document PyDoc_STRVAR and PyDoc_STR macros (pythonGH-16607)
  bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (pythonGH-19725)
  bpo-40387: Improve queue join() example. (pythonGH-19724)
  bpo-40396: Support GenericAlias in the typing functions. (pythonGH-19718)
  Fix typo in Lib/typing.py (pythonGH-19717)
  Fix typo in object.__format__ docs (pythonGH-19504)
  bpo-40275: Avoid importing logging in test.support (pythonGH-19601)
  bpo-40275: Avoid importing socket in test.support (pythonGH-19603)
  bpo-40275: Avoid importing asyncio in test.support (pythonGH-19600)
  bpo-40279: Add some error-handling to the module initialisation docs example (pythonGH-19705)
  closes bpo-40385: Remove Tools/scripts/checkpyc.py (pythonGH-19709)
  bpo-40334: Add What's New sections for PEP 617 and PEP 585 (pythonGH-19704)
  bpo-40340: Separate examples more clearly in the programming FAQ (pythonGH-19688)
  bpo-40360: Deprecate lib2to3 module in light of PEP 617 (pythonGH-19663)
  bpo-40334: Rewrite test_c_parser to avoid memory leaks (pythonGH-19694)
  bpo-38061: subprocess uses closefrom() on FreeBSD (pythonGH-19697)
  bpo-38061: os.closerange() uses closefrom() on FreeBSD (pythonGH-19696)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants