Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 21, 2017
Merged

bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX #202

merged 5 commits into from
Feb 21, 2017

Conversation

MatthieuDartiailh
Copy link
Contributor

No description provided.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement
  2. Wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Feb 20, 2017
methane
methane requested changes Feb 21, 2017
View reviewed changes
Copy link
Member

@methane methane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to Misc/NEWS ?

It might be like this:

Core and Builtins
-----------------

- bpo-29607: Fix stack effect computation for CALL_FUNCTION_EX opcode.

serhiy-storchaka
serhiy-storchaka reviewed Feb 21, 2017
View reviewed changes
Misc/NEWS Outdated
@@ -10,6 +10,8 @@ What's New in Python 3.7.0 alpha 1?
Core and Builtins
-----------------

- bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX
Copy link
Member

@serhiy-storchaka serhiy-storchaka Feb 21, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add "Patch by <yourname>."

serhiy-storchaka
serhiy-storchaka reviewed Feb 21, 2017
View reviewed changes
Misc/NEWS Outdated
@@ -10,6 +10,9 @@ What's New in Python 3.7.0 alpha 1?
Core and Builtins
-----------------

- bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX.
Patch by Matthieu Dartiailh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a period at the end of the entry.

@serhiy-storchaka serhiy-storchaka merged commit 3a9ac82 into python:master Feb 21, 2017
@MatthieuDartiailh MatthieuDartiailh deleted the MatthieuDartiailh-patch-1 branch February 21, 2017 13:45
methane pushed a commit to methane/cpython that referenced this pull request Feb 21, 2017
@MatthieuDartiailh @methane
bpo-29607: Fix stack_effect computation for CALL_FUNCTION_EX (python#202
49cf87c 
)

(cherry picked from commit 3a9ac82)
@methane methane mentioned this pull request Feb 21, 2017
Merged
@methane
Copy link
Member

methane commented Feb 21, 2017

@MatthieuDartiailh I'm sorry, but I missed "CLA not signed" label.
Could you sign CLA? Or have you already signed and waiting it's reviewed?

@MatthieuDartiailh
Copy link
Contributor Author

It is waiting to be reviewed.

@serhiy-storchaka
Copy link
Member

I think signing CLA is not required for such trivial change. Since the bug was reported anyone could write the patch.

But if Matthieu wants to continue his contributing, signing CLA is required.

@MatthieuDartiailh MatthieuDartiailh mentioned this pull request Feb 26, 2017
Closed
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#202: remove the STACKLESS_DECLARE_METHOD magic
414d410 
Now that we have C99 designated initializers, we don't need the
STACKLESS_DECLARE_METHOD magic any longer. Replacing it with explicit
initializers has several advantages:
- faster startup time
- less magic, code is simpler to reason about
- no memory leak
- no initialization race for sub-types between init_stackless_methods()
  and PyType_Ready().
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 12, 2019
Stackless issue python#202: remove the STACKLESS_DECLARE_METHOD magic
b8a98a8 
Now that we have C99 designated initializers, we don't need the
STACKLESS_DECLARE_METHOD magic any longer. Replacing it with explicit
initializers has several advantages:
- faster startup time
- less magic, code is simpler to reason about
- no memory leak
- no initialization race for sub-types between init_stackless_methods()
  and PyType_Ready().
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @asvetlov
Update aiohttp from 3.5.3 to 3.5.4 (#202)
880e91f
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Drop py35 from tox. Ref python#202.
c3044eb
isidentical pushed a commit to isidentical/cpython that referenced this pull request Mar 21, 2023
@pablogsal
Fix infinite loop when displaying warnings (python#202)
edc5734 
Signed-off-by: Pablo Galindo <[email protected]>

Signed-off-by: Pablo Galindo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MatthieuDartiailh @the-knights-who-say-ni @methane @serhiy-storchaka @Mariatta