bpo-40679: use a function's qualname in error messages #20236

sweeneyde · 2020-05-19T19:36:16Z

https://bugs.python.org/issue40679

cjerdonek

Here are a couple comments. Thanks for the PR!

Misc/NEWS.d/next/Core and Builtins/2020-05-19-19-39-49.bpo-40679.SVzz9p.rst

Lib/test/test_keywordonlyarg.py

bedevere-bot · 2020-05-19T23:46:16Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

sweeneyde · 2020-05-20T07:17:39Z

Python/ceval.c

@@ -4180,7 +4181,7 @@ _PyEval_EvalCode(PyThreadState *tstate,
        if (keyword == NULL || !PyUnicode_Check(keyword)) {
            _PyErr_Format(tstate, PyExc_TypeError,
                          "%U() keywords must be strings",
-                          co->co_name);
+                          qualname);


Are there any suggestions for how to test this from Python? I couldn't figure out how without getting a SyntaxError.

Using the ** should do the trick.
For example:

>>> func = lambda *args, **kwargs: None >>> kwargs = {None: None} >>> func(kwargs) >>> func(*kwargs) >>> func(**kwargs) Traceback (most recent call last): File "<stdin>", line 1, in <module> TypeError: <lambda>() keywords must be strings

Unfortunately it looks like this behavior changed a bit in the newest releases so that that code isn't actually reached:

PS > py -3.7 -c "f = lambda x: None; f(**{1:1})" Traceback (most recent call last): File "<string>", line 1, in <module> TypeError: <lambda>() keywords must be strings PS > py -3.8 -c "f = lambda x: None; f(**{1:1})" Traceback (most recent call last): File "<string>", line 1, in <module> TypeError: <lambda>() keywords must be strings PS > py -3.9 -c "f = lambda x: None; f(**{1:1})" Traceback (most recent call last): File "<string>", line 1, in <module> TypeError: keywords must be strings

Oh I see... Probably related to 0567786 .

cjerdonek

I think the earlier version where you're using traditional TestCase classes is a bit better because it's more idiomatic. I'm not sure why that large doctest is being used like that.

Also, since assertRaisesRegex() is annoying to use when you're just trying to test equality, you could define a context manager helper method on your test class as your own replacement. It could look something like this:

with self.assertRaises(TypeError) as cm:
    yield
exc = cm.exception
self.assertEqual(str(exc), '<message>')

That would eliminate some boilerplate.

sweeneyde · 2020-05-21T06:11:12Z

@cjerdonek I switched it back to a standard unittest.TestCase and refactored as you suggested.

cjerdonek

Good work! A few nits, and I think this is good to go. 👍

Lib/test/test_call.py

Misc/NEWS.d/next/Core and Builtins/2020-05-19-19-39-49.bpo-40679.SVzz9p.rst

Lib/test/test_call.py

sweeneyde · 2020-05-21T18:43:59Z

One of the tests (test_ttk_guionly) on Ubuntu is hanging on this line:

cpython/Lib/tkinter/test/test_ttk/test_extensions.py

Line 190 in e42b705

x.wait_visibility()

but I think that is unrelated. I think this might be a common intermittent issue.

cjerdonek · 2020-05-21T22:12:56Z

Another thing to do to retrigger CI is to do “git commit —amend” (with no changes) followed by “git push —force-with-lease”.

…

On Thu, May 21, 2020 at 1:00 PM Dennis Sweeney ***@***.***> wrote: Reopened #20236 <#20236>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACW33R5M4JFGH6RHXACWITRSWB6JANCNFSM4NFJJGUA> .

cjerdonek · 2020-05-21T22:14:59Z

Thanks. Can you file an issue if there isn’t already one?

…

On Thu, May 21, 2020 at 11:44 AM Dennis Sweeney ***@***.***> wrote: One of the tests (test_ttk_guionly) on Ubuntu is hanging on this line: https://github.com/python/cpython/blob/e42b705188271da108de42b55d9344642170aa2b/Lib/tkinter/test/test_ttk/test_extensions.py#L190 but I think that is unrelated. I think this might be a common intermittent issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20236 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACW33UMATD2MNKDZ54LFRDRSVY75ANCNFSM4NFJJGUA> .

sweeneyde · 2020-05-21T22:51:02Z

Thanks -- good to know.

I opened https://bugs.python.org/issue40722.

cjerdonek · 2020-05-22T20:42:05Z

Thanks again for your good work on this, @sweeneyde.

…H-20236) Patch by Dennis Sweeney.

Related tickets/PRs: * python/cpython#20236 * https://twistedmatrix.com/trac/ticket/10273 git-svn-id: file:///srv/repos/svn-community/svn@1065036 9fca08f4-af9d-4005-b8df-a31f2cc04f65

use a function's qualname in error messages

c1ff4d0

the-knights-who-say-ni added the CLA signed label May 19, 2020

bedevere-bot added the awaiting review label May 19, 2020

📜🤖 Added by blurb_it.

cced9d7

cjerdonek requested changes May 19, 2020

View reviewed changes

Misc/NEWS.d/next/Core and Builtins/2020-05-19-19-39-49.bpo-40679.SVzz9p.rst Outdated Show resolved Hide resolved

Lib/test/test_keywordonlyarg.py Show resolved Hide resolved

bedevere-bot added awaiting changes and removed awaiting review labels May 19, 2020

Make changes from review

495cb4b

sweeneyde commented May 20, 2020

View reviewed changes

sweeneyde added 2 commits May 20, 2020 15:24

move testst to test_extcall.py

fb792e2

remove unused test setup

41e3e72

cjerdonek reviewed May 21, 2020

View reviewed changes

use standard unittest.TestCase, refactor error message checking

0463db7

cjerdonek reviewed May 21, 2020

View reviewed changes

Lib/test/test_call.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Core and Builtins/2020-05-19-19-39-49.bpo-40679.SVzz9p.rst Outdated Show resolved Hide resolved

Lib/test/test_call.py Outdated Show resolved Hide resolved

Make changes from review

943b068

sweeneyde closed this May 21, 2020

sweeneyde reopened this May 21, 2020

cjerdonek approved these changes May 22, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels May 22, 2020

cjerdonek added 2 commits May 21, 2020 18:52

Tweak and fix typo in NEWS entry.

5b77780

Add "Patch by" to NEWS entry.

07fa955

cjerdonek merged commit b5cc208 into python:master May 22, 2020

bedevere-bot removed the awaiting merge label May 22, 2020

arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020

bpo-40679: Use the function's qualname in certain TypeErrors (pythonG…

0d8a592

…H-20236) Patch by Dennis Sweeney.

yan12125 mentioned this pull request Dec 7, 2021

Python 3.10.0a1: FAIL: sure.that_with_context() when no context is given it fails gabrielfalcao/sure#169

Open

1 task

sweeneyde deleted the func_qualname branch January 25, 2022 23:10

Uh oh!

bpo-40679: use a function's qualname in error messages #20236

bpo-40679: use a function's qualname in error messages #20236

Uh oh!

Conversation

sweeneyde commented May 19, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjerdonek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented May 19, 2020

Uh oh!

sweeneyde May 20, 2020

Choose a reason for hiding this comment

Uh oh!

SylvainDe May 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sweeneyde May 20, 2020

Choose a reason for hiding this comment

Uh oh!

SylvainDe May 20, 2020

Choose a reason for hiding this comment

Uh oh!

cjerdonek left a comment

Choose a reason for hiding this comment

Uh oh!

sweeneyde commented May 21, 2020

Uh oh!

cjerdonek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sweeneyde commented May 21, 2020

Uh oh!

cjerdonek commented May 21, 2020 via email

Uh oh!

cjerdonek commented May 21, 2020 via email

Uh oh!

sweeneyde commented May 21, 2020

Uh oh!

cjerdonek commented May 22, 2020

Uh oh!

Uh oh!

sweeneyde commented May 19, 2020 •

edited by bedevere-bot

Loading

cjerdonek left a comment •

edited

Loading

SylvainDe May 20, 2020 •

edited

Loading