[3.8] bpo-35714: Reject null characters in struct format strings (GH-16928) #20419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honGH-16928) struct.error is now raised if there is a null character in a struct format string. (cherry picked from commit 3f59b55) Co-authored-by: Zackery Spytz <[email protected]>
serhiy-storchaka
approved these changes
May 26, 2020
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-20420 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 26, 2020
…honGH-16928) (pythonGH-20419) struct.error is now raised if there is a null character in a struct format string. (cherry picked from commit 3f59b55) (cherry picked from commit 5ff5edf) Co-authored-by: Zackery Spytz <[email protected]>
|
Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
May 26, 2020
…16928) (GH-20419) struct.error is now raised if there is a null character in a struct format string. (cherry picked from commit 3f59b55) (cherry picked from commit 5ff5edf) Co-authored-by: Zackery Spytz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct.error is now raised if there is a null character in a struct
format string.
(cherry picked from commit 3f59b55)
https://bugs.python.org/issue35714