bpo-40637: Don't test builtin PBKDF2 without builtin hashes (GH-20980) #20980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without yet looking at the code, I can verify that this PR fixes the stderr noise on the RHEL8 FIPS enabled builbot and also clears the warning: Warning -- logging._handlerList was modified by test_hashlib Also minor typo: s/hashses/hashes |
|
Relevant buildbot: https://buildbot.python.org/all/#/builders/764/builds/150 |
Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <[email protected]>
a5e11d5 to
0866ed3
Compare
|
I have been asked to review this change. Honestly, I don't feel able to review this PR. I tried but failed to understand the complexity of hashlib build options and FIPS mode. If you are confident and @stratakis confirms that this change fix his issue, just merge your PR. |
kk456852
approved these changes
Jul 10, 2020
|
Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2020
…-20980) Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit 975022b) Co-authored-by: Christian Heimes <[email protected]>
|
GH-23343 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 17, 2020
Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <[email protected]> (cherry picked from commit 975022b) Co-authored-by: Christian Heimes <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…-20980) Skip testing of pure Python PBKDF2 when one or more builtin hash module is not available. Otherwise the import of hashlib prints noise on stderr. Signed-off-by: Christian Heimes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip testing of pure Python PBKDF2 when one or more builtin hash module
is not available. Otherwise the import of hashlib prints noise on
stderr.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue40637