Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-83274: Stop deallocation of Tkapp causing Python interpreter crash #21532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

gh-83274: Stop deallocation of Tkapp causing Python interpreter crash #21532

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
63143f0
Stop deallocation of Tkapp causing Python interpreter crash
E-Paine Jul 18, 2020
853135a
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 18, 2020
b34dfa1
Added test for gc thread crash
E-Paine Jul 18, 2020
d084fc8
Attempted test fixes
E-Paine Jul 18, 2020
eb28228
Attempt to debug Ubuntu failure
E-Paine Jul 18, 2020
b58c49c
Further attempt to debug Ubuntu failure
E-Paine Jul 19, 2020
167ea91
Fix bytes problem
E-Paine Jul 19, 2020
93297b6
Attempted fix for Ubuntu failure
E-Paine Jul 19, 2020
bea2cef
Reduce subprocess duration
E-Paine Jul 19, 2020
a29f9ec
Changed subprocess to use threading events
E-Paine Jul 19, 2020
7c1312d
Removed un-needed import
E-Paine Jul 19, 2020
f15f000
Removed redundant threading event
E-Paine Jul 20, 2020
2f28f0a
Use lambda for thread
E-Paine Jul 20, 2020
558512a
Merge branch 'master' into tkapp-gc
E-Paine Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempted fix for Ubuntu failure
  • Loading branch information
@E-Paine
E-Paine committed Jul 19, 2020
commit 93297b651193069457ac798f3950dbbc25726b2b
9 changes: 4 additions & 5 deletions Lib/tkinter/test/test_tkinter/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,10 @@ def test_thread_gc(self):
stdout, stderr = p.communicate()
stderr = stderr.strip()
try:
self.assertEqual(stderr,
b"Exception ignored in: 'Deallocation of Tkapp "
b"attempted in wrong thread. Skipping deletion of "
b"Tcl interpreter (this will cause a memory "
b"leak).'")
self.assertTrue(b"Exception ignored in: <class 'RuntimeWarning'>" in stderr)
self.assertTrue(b"RuntimeWarning: Deallocation of Tkapp attempted in wrong "
b"thread. Skipping deletion of Tcl interpreter (this will "
b"cause a memory leak)." in stderr)
except AssertionError:
# If there is an error in the subprocess
# we need to be able to debug it
Expand Down
6 changes: 4 additions & 2 deletions Modules/_tkinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3043,9 +3043,11 @@ Tkapp_Dealloc(PyObject *self)
if (((TkappObject *)self)->threaded && \
((TkappObject *)self)->thread_id != Tcl_GetCurrentThread()) {
// We cannot delete the interpreter in the wrong thread (bpo-39093)
PyErr_WriteUnraisable(PyUnicode_FromString("Deallocation of Tkapp " \
PyErr_SetString(PyExc_RuntimeWarning, "Deallocation of Tkapp " \
"attempted in wrong thread. Skipping deletion of Tcl " \
"interpreter (this will cause a memory leak)."));
"interpreter (this will cause a memory leak).");
PyErr_WriteUnraisable(PyErr_Occurred());
PyErr_Clear();
} else {
ENTER_TCL
Tcl_DeleteInterp(Tkapp_Interp(self));
Expand Down