-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-42382: Make sure each EntryPoint
carries it's Distribution
information
#23334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
0417c33
to
07838f8
Compare
07838f8
to
2a12884
Compare
CLA signed 🎉 Sorry for the direct ping @jaraco but I think you're probably the best person to review? |
Polite ping. |
@brettcannon you might be interested in review the PR |
Always happy to have a direct ping. I missed the earlier notice (or hadn't yet gotten to it), so the bump helped ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good. I think it's on the right track. I'd like to explore the possibility of not storing the 'name' separately from the Distribution object (just store the object). I'm unsure what cases that might break though.
Also, I'll probably want to submit the Python 3.6-compatible backport at importlib_metadata first, and then incorporate those changes into CPython as part of the porting process.
That's not strictly necessary, though. It is faster and easier to test in that project.
Superseded by #23758. |
This avoids a low performance workaround to get the
EntryPoint
'sDistribution
, for example:https://bugs.python.org/issue42382