Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-41861: Add NEWS and normalise _sqlite3 Cache/Node type struct naming #23337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 17, 2020

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 17, 2020

@corona10 Would you mind taking a quick look at this? Just closing bpo-41861 by adding a NEWS entry and normalising Cache/Node struct names (so that the naming is consistent with the other type structs in _sqlite3.)

(I closed #22419, since it went in limbo.)

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 17, 2020

Can you provide a discussion about normalizing?
we often do not accept this kind of PR ;)

Yes, I'm aware of that, but since this is the final PR of bpo-41861, I thought an exception would be acceptable, since the other PR's relating to this bpo have used this naming scheme ;) Please? :)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner vstinner merged commit 2ffba2a into python:master Nov 17, 2020
@vstinner
Copy link
Member

Merged. I rewrote your commit message to make it shorter.

@erlend-aasland erlend-aasland deleted the bpo-41861/final branch November 17, 2020 13:32
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants