Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix a typo #24169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

Fix a typo #24169

merged 1 commit into from
Jan 8, 2021

Conversation

jdahlin
Copy link
Contributor

@jdahlin jdahlin commented Jan 8, 2021

Return param spec should be R, not T

@jdahlin
Fix a typo
43188f9 
Return param spec should be R, not T
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jdahlin

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 8, 2021
@jdahlin
Copy link
Contributor Author

jdahlin commented Jan 8, 2021

Not sure if it's necessary for typos, but I just signed the CLA for this.

gvanrossum
gvanrossum approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge. (CC: @Fidget-Spinner)

@gvanrossum gvanrossum merged commit 68e1f25 into python:master Jan 8, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@Fidget-Spinner
Copy link
Member

Thanks for catching this! And congrats on your first contribution to CPython :).

PS.
Thanks to this, I noticed another mistake in the same example too.

@Fidget-Spinner Fidget-Spinner mentioned this pull request Jan 9, 2021
Merged
miss-islington pushed a commit that referenced this pull request Jan 11, 2021
@Fidget-Spinner
Fix various ParamSpec errors in typing (GH-24176)
ace008c 
1. ParamSpec -> TypeVar for ``typing.Concatenate``
2. ParamSpec's call signature should align with its documentation.
Noticed in GH-24169
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@jdahlin @adorilson
Fix a typo in docs for typing.Concatenate (python#24169)
5889430 
Return param spec should be R, not T
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
Fix various ParamSpec errors in typing (pythonGH-24176)
bcfd189 
1. ParamSpec -> TypeVar for ``typing.Concatenate``
2. ParamSpec's call signature should align with its documentation.
Noticed in pythonGH-24169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdahlin @the-knights-who-say-ni @bedevere-bot @Fidget-Spinner @gvanrossum