html.parser: fix ‘<![CDATA[ ... ]]>’ handling not capturing ‘]’ #24720
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Per documentation, the unknown_decl method is called with ‘the entire contents of the declaration inside the <![...]> markup.’ However, this is not quite the case for ‘<![CDATA[...]]>’ where the first of the two final closing square brackets should be included but isn’t. In other words, for such declaration unknown_decl is called with ‘CDATA[...’ string (observe unmatched brackets). Not including the closing bracket doesn’t fit the documentation but also makes it impossible to output the declaration without change since ‘"<![" + data + "]>"’ eats one of the brackets at the end. Fix by including the first of the closing brackets when calling unknown_decl.
Yeah… Still waiting for my email address confirmation email… |
|
This PR is stale because it has been open for 30 days with no activity. |
|
@ezio-melotti, any chance of getting this reviewed? |
Per documentation, the unknown_decl method is called with ‘the entire
contents of the declaration inside the
<![...]>markup.’ However,this is not quite the case for
<![CDATA[...]]>where the first ofthe two final closing square brackets should be included but isn’t.
In other words, for such declaration unknown_decl is called with
CDATA[...string (observe unmatched brackets).Not including the closing bracket doesn’t fit the documentation but
also makes it impossible to output the declaration without change
since
"<![" + data + "]>"eats one of the brackets at the end.Fix by including the first of the closing brackets when calling
unknown_decl.