Thanks to visit codestin.com
Credit goes to github.com

Skip to content

socket documentation fix - rename triple to 3-tuple #24722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

OriHoch
Copy link
Contributor

@OriHoch OriHoch commented Mar 3, 2021

was a bit confusing to me looking at this doc, wasn't sure what a triple meant, also, I believe it has other meanings in different contexts..

Searching the docs I see a lot of usages of 3-tuple, so I assume it's more standard.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@OriHoch

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 3, 2021
@OriHoch OriHoch changed the title docket documentation fix - rename triple to 3-tuple socket documentation fix - rename triple to 3-tuple Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Apr 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Apr 3, 2021
@ammaraskar ammaraskar added skip issue skip news and removed stale Stale PR or inactive for long period of time. labels Aug 2, 2021
@ammaraskar
Copy link
Member

Closing and re-opening to trigger CI.

@ammaraskar ammaraskar closed this Aug 2, 2021
@ammaraskar ammaraskar reopened this Aug 2, 2021
@MaxwellDupre
Copy link
Contributor

Cant build, cant review:
~/D/G/cpython   socket-doc-rename-triple-to-3-tuple $…  make -C Doc/ html
make: Entering directory '/home/me/Documents/GitHub/cpython/Doc'
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
PATH=./venv/bin:$PATH sphinx-build -b html -d build/doctrees -W . build/html
Running Sphinx v4.5.0
loading pickled environment... done
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 491 source files that are out of date
updating environment: [config changed ('version')] 485 added, 0 changed, 9 removed
reading sources... [100%] whatsnew/index

Warning, treated as error:
/home/me/Documents/GitHub/cpython/Doc/c-api/complex.rst:49:Error in declarator or parameters
Error in declarator or parameters
Invalid C declaration: Expected identifier, got user-defined keyword: complex. Remove it from c_extra_keywords to allow it as identifier.
Currently c_extra_keywords is ['alignas', 'alignof', 'bool', 'complex', 'imaginary', 'noreturn', 'static_assert', 'thread_local']. [error at 39]
Py_complex _Py_c_neg(Py_complex complex)
---------------------------------------^
make: *** [Makefile:51: build] Error 2

@AA-Turner
Copy link
Member

wasn't sure what a triple meant

In mathematics, a triple is a common name for a tuple of three elements.

I'm +0 on this change.

A

@AA-Turner
Copy link
Member

Closing & re-opening to re-trigger CLA.

@slateny
Copy link
Contributor

slateny commented Jan 9, 2023

I think that one could deduce that triple = 3-tuple just by context, but since socket isn't a math-related module I'd be +1 for changing it to avoid confusion (and to be a bit more consistent).

Copy link

@EmberCraze EmberCraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 7, 2023
@hugovk hugovk enabled auto-merge (squash) September 7, 2023 10:27
@hugovk hugovk merged commit 6b15ff5 into python:main Sep 7, 2023
@miss-islington
Copy link
Contributor

Thanks @OriHoch for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-109073 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2023
(cherry picked from commit 6b15ff5)

Co-authored-by: Ori Hoch <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 7, 2023
(cherry picked from commit 6b15ff5)

Co-authored-by: Ori Hoch <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-bot
Copy link

GH-109074 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 7, 2023
hugovk added a commit that referenced this pull request Sep 7, 2023
Yhg1s pushed a commit that referenced this pull request Sep 8, 2023
…#109073)

socket documentation fix - rename triple to 3-tuple (GH-24722)
(cherry picked from commit 6b15ff5)

Co-authored-by: Ori Hoch <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.